From nobody Wed Jan 18 21:36:16 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NxzbQ2BkMz2t3s3 for ; Wed, 18 Jan 2023 21:36:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NxzbQ10M5z46w3 for ; Wed, 18 Jan 2023 21:36:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674077778; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YvM1i1Mzq8qy4TbMNQqV3e9j7ZRVZ/T1OZfCX1mvg3U=; b=q+nGn5EailmZ5jwUrr83nYp3jWik4Vv2nix1DPOyN7NOQJ6rjqJS2jXhVmeRWgD5WUoduR wOrBllPApMk/Ia7Ln8YkAzOixKlcX/EaS0JkZS45HTNTODUbjjWz9D2aNS88GqScNkp6AA IzOHFRR0yiMBIWkm7PiAW/gJaFDn2YZCU1OKzzvWV+nUb42zoGcb1TtfBj1sVh+qYZQoOM bMCtCwX8q3OJc9yH5KO4VcYZVt/sbQsC3cKQQkzsrnjU6wM3zcUgub7i4rLh/hv3RLs2w8 957vEBuCpW7Tk4gu8qowglNKt95gw/KJQVQrtXxJa/i37S4qKd9gmU0PKSHzxg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674077778; a=rsa-sha256; cv=none; b=JbOWqVpIlBr7fyREGtdl1R0e+5dz9iSu6RZnUpbopu/bJxt1hoLT6e4Tdoxtcb80+YDaaf LdXAZ3iuVo8MWzl6SMjhX7MkYTHhg2yszEEyRssnkCX2FtY92rHEOg6QXn2jQLSMI4jH7z w9WZr/Pf4Yt6I91PqvRMYlqlMgEElGyGd45NmkZbUkqI2cF/3fipdXMR6xI1CJOYVRu/WP ZmeieUpfuRj5evNdUWkjyN6OZxhNKGOrPez1j7v879UiowM61qmRO8Uz1Jkq+NYcJxCDQK j5eueo4jP+JGl2PgcCQkh/HUut332mkBIplpRWyy0eDMdT4EEZ+pM37v/eva5g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NxzbQ04JTzR0d for ; Wed, 18 Jan 2023 21:36:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 30ILaHpr029279 for ; Wed, 18 Jan 2023 21:36:17 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 30ILaHw1029278 for bugs@FreeBSD.org; Wed, 18 Jan 2023 21:36:17 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 185619] [VNET] Name conflict not checked when a child vnet goes away and returns its interface(s) back to the parent Date: Wed, 18 Jan 2023 21:36:16 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kp@freebsd.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D185619 --- Comment #5 from Kristof Provost --- (In reply to Zhenlei Huang from comment #4) I currently don't have any strong opinions on the best path to take here. My initial thought was to, on return-to-home-vnet, check for name conflicts= and to rename if there was one. That's somewhat unpredictable though. On the other hand, tracking globally unique names risks significant complex= ity (because some interfaces are created in a vnet, i.e. not all interfaces have vnet0 as their home vnet), and also risks leaking information between vnets (i.e. vnet1 creates an epair interface, and now knows there are 5 other epa= irs on the system, because it got epair6a/b). That's probably not hugely import= ant though. I will point out that I recall looking at related issues and discovering th= at the locking and error handling around interface renaming is either beyond m= e or just plain incorrect. --=20 You are receiving this mail because: You are the assignee for the bug.=