From nobody Thu Aug 17 14:07:43 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RRRfR3MDNz4qhkl for ; Thu, 17 Aug 2023 14:07:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RRRfR1Rw5z4nCS for ; Thu, 17 Aug 2023 14:07:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692281263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F1nMFMhZMgRNUFSyCiPrv1JLK8sqp6oIActXfyuw1Yo=; b=taHS72qzjiYMJ40D5o6CGvBitgKivW4gu+DfUtoCiwfozBE7Oq3FKex7sBqwZLWcQ44+0w deujlmaVOd38Nx0IXfZ2U4eNm4uFAsJ1FY8c0QgZqunrzokm5qBGvPXYHpTlU0YI/ckTvv LONlL4bd0Z64R4N3Gt5R4BaQqv8DbZIw1rlUylLvzefSiAYhkkBgA1HxoIGHKlA5T9sYWx hS7XXWrU+yiCR2p9pX38l9TU5zt4gib0+PWSam+GnDszqx99x9wGWd7Mto+69B7+ap1EMD /jlc/+iA+yu6zjmO44xM9Dv+U1YY8so1G3llqza3BlIbs6zpDQJ6D3HbxFpecQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1692281263; a=rsa-sha256; cv=none; b=Pe6fKB6hevpQRFd+iUth6bOPtqsjnK+kT1U+z10KOn0cNYfZ1kEaZpKnAzl0K/bmAiDXUu 1isM2ut/3aeaSV9Y3XC/ItT+iV5bm3lFGoqmNpuSnUHPgZSBcpOJ+av+zc+zqCuiB2YYoB BIpWKqoHsNBkMk/xLLBvlPbEOePOOw97rae5HCWvVTfCwa8IcfqsxU31SFvFEkYoq/rC+m 3yhoEND+cULnBFC9Cuys+1h25WhhtnZntUMOpLNVPihWC3ZqocHw4VJwGTY+tllqhbKHo0 WpQAOeN5LJ14bY4RJJRTss7WHJG2IFeNcdwNyrI/Ewe/XcNLFVlZS9kCg1wu2A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RRRfR0Wjlzcp8 for ; Thu, 17 Aug 2023 14:07:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 37HE7hUa019450 for ; Thu, 17 Aug 2023 14:07:43 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 37HE7h58019449 for bugs@FreeBSD.org; Thu, 17 Aug 2023 14:07:43 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 273022] MSI/MSI-X assignment fails if APIC ID > 255 Date: Thu, 17 Aug 2023 14:07:43 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273022 --- Comment #3 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D044dfb356bb6481af4de4ed0f7ef04c3b= 638bf71 commit 044dfb356bb6481af4de4ed0f7ef04c3b638bf71 Author: Ed Maste AuthorDate: 2023-08-08 23:42:09 +0000 Commit: Ed Maste CommitDate: 2023-08-17 14:06:39 +0000 msi: report error for attempt to use APIC ID > 255 The MSI/MSI-X address includes 8 bits to encode the Destination ID. Previously IDs over 255 overlapped with the fixed portion of the address, resulting in an invalid value (and a nonfunctional interrupt). Instead, print an error message and return EINVAL. The interrupt will still not work, but the user will have a clue as to why. PR: 273022 Reviewed by: jhb Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D41395 (cherry picked from commit cbf845052f1c2862a64e66dbaf38e887a7592474) sys/x86/x86/msi.c | 5 +++++ 1 file changed, 5 insertions(+) --=20 You are receiving this mail because: You are the assignee for the bug.=