From nobody Thu Apr 27 17:06:19 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q6hwC5v6Rz47Qfk for ; Thu, 27 Apr 2023 17:06:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q6hwC4r4fz3nx5 for ; Thu, 27 Apr 2023 17:06:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682615179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wpGRhvYfFhJJyh6lFn+qPRHyE7stjc83DhKaBFTsiWY=; b=d5A03IM61vtgz5/NRMarb+Tu9mJ2T72nBF0Xrsfl15oJ4znD3lzX3zQ8MWDRQRLDCB8Aet J+EDJ9iS/UXavsjrtB0suNXxR4YgP3Nhy9z37UIigUmr06grIzaxrAq8M36caq2P6PpVW0 XIFo52xR4vCLwt2sG9lLmsi5wGr1lBgRmHvV2+wlLSfQgIktUJa3VJeVUVOZAtXInbH/RL 1z+rl1YxTFgywdxNBhZVTvp91A97HVHiI2YTENt04TiYDmL4QGvU2dOqGF0xTF78yr10uK 3GZMHOFtkV6xJJKGuC9d+TF+Mf4WXAKYlO65XnaxL4WrMDxFVHstJzimv1cPEA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1682615179; a=rsa-sha256; cv=none; b=tRDUekj4guJW2PeUNHsmk+/oCj8VwDlZ2OTwY3rAHdHqQHu0qpaU9qeOVwF+1Uf0vGHXEJ r0PHNDznfVS+rtbyW4l7QHVpEup7ShDZsE7FzYkFLD+QE1Iyd2S/ZcVW+Hg4E3UEoCMvDO SnmtxindOLhvzklBQMzyrzlQAByB+Nr0P5OBZarbwMCIfLVbz3P8UkYBcIFzfj5QwGVOUk qI/RM8l7UZzOfq63dhDOdcNr9HGsXnorQOpmzmZrG58NczuHXPwAxiR8qFnxmaemsP+OPa T5/tVqr2nsHdQjaY8RUIEWnkcnPtWBtXCTuWruPFCnrlwW9W+1PyNp3xFVe0uw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Q6hwC3q0SzQSl for ; Thu, 27 Apr 2023 17:06:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 33RH6JVF020752 for ; Thu, 27 Apr 2023 17:06:19 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 33RH6J4O020751 for bugs@FreeBSD.org; Thu, 27 Apr 2023 17:06:19 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 271101] cxgbe(4): panic due to lock recursion while creating tracing interface Date: Thu, 27 Apr 2023 17:06:19 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: np@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271101 --- Comment #2 from Navdeep Parhar --- I tried to see if making the driver sx recursive would fix the problem but = ran into a different assertion in if_clone.c diff --git a/sys/dev/cxgbe/t4_tracer.c b/sys/dev/cxgbe/t4_tracer.c index 00c403b59bba..25316eec77f8 100644 --- a/sys/dev/cxgbe/t4_tracer.c +++ b/sys/dev/cxgbe/t4_tracer.c @@ -233,7 +233,7 @@ void t4_tracer_modload(void) { - sx_init(&t4_trace_lock, "T4/T5 tracer lock"); + sx_init_flags(&t4_trace_lock, "T4/T5 tracer lock", SX_RECURSE); t4_cloner =3D if_clone_advanced(t4_cloner_name, 0, t4_cloner_match, t4_cloner_create, t4_cloner_destroy); } (kgdb) p panicstr $1 =3D 0xffffffff8219e380 "Assertion ifd->ifp !=3D NULL faile= d at /root/ws/dev/sys/net/if_clone.c:415" (kgdb) bt #0 0xffffffff80fdb06b in doadump (textdump=3D1) at /root/ws/dev/sys/kern/kern_shutdown.c:407 #1 0xffffffff80fdaca9 in kern_reboot (howto=3D260) at /root/ws/dev/sys/kern/kern_shutdown.c:528 #2 0xffffffff80fdb7c9 in vpanic (fmt=3D0xffffffff819ba49d "Assertion %s fa= iled at %s:%d", ap=3D0xfffffe0088fc8970) at /root/ws/dev/sys/kern/kern_shutdown.= c:972 #3 0xffffffff80fdb00e in panic (fmt=3D0xffffffff819ba49d "Assertion %s fai= led at %s:%d") at /root/ws/dev/sys/kern/kern_shutdown.c:896 #4 0xffffffff811a96e0 in if_clone_createif_nl (ifc=3D0xfffff80001c72300, ifname=3D0xfffffe0088fc8d98 "t6nex0", ifd=3D0xfffffe0088fc8a10) at /root/ws/dev/sys/net/if_clone.c:415 #5 0xffffffff811a949f in ifc_create_ifp (name=3D0xfffffe0088fc8d98 "t6nex0= ", ifd=3D0xfffffe0088fc8aa0, ifpp=3D0xfffffe0088fc8a98) at /root/ws/dev/sys/net/if_clone.c:215 #6 0xffffffff811a9803 in if_clone_create (name=3D0xfffffe0088fc8d98 "t6nex= 0", len=3D16, params=3D0x0) at /root/ws/dev/sys/net/if_clone.c:243 #7 0xffffffff811a235e in ifioctl (so=3D0xfffff80009186780, cmd=3D322334962= 8, data=3D0xfffffe0088fc8d98 "t6nex0", td=3D0xfffff80009db9740) at /root/ws/dev/sys/net/if.c:3048 #8 0xffffffff810a0f53 in soo_ioctl (fp=3D0xfffff80001f512d0, cmd=3D3223349= 628, data=3D0xfffffe0088fc8d98, active_cred=3D0xfffff8000198e100, td=3D0xfffff80= 009db9740) at /root/ws/dev/sys/kern/sys_socket.c:267 #9 0xffffffff8109234e in fo_ioctl (fp=3D0xfffff80001f512d0, com=3D32233496= 28, data=3D0xfffffe0088fc8d98, active_cred=3D0xfffff8000198e100, td=3D0xfffff80= 009db9740) at /root/ws/dev/sys/sys/file.h:367 #10 0xffffffff81092124 in kern_ioctl (td=3D0xfffff80009db9740, fd=3D3, com=3D3223349628, data=3D0xfffffe0088fc8d98 "t6nex0") at /root/ws/dev/sys/kern/sys_generic.c:807 #11 0xffffffff81091d81 in sys_ioctl (td=3D0xfffff80009db9740, uap=3D0xfffff80009db9b38) at /root/ws/dev/sys/kern/sys_generic.c:715 #12 0xffffffff817a68f9 in syscallenter (td=3D0xfffff80009db9740) at /root/ws/dev/sys/amd64/amd64/../../kern/subr_syscall.c:190 #13 0xffffffff817a603b in amd64_syscall (td=3D0xfffff80009db9740, traced=3D= 0) at /root/ws/dev/sys/amd64/amd64/trap.c:1199 #14 #15 0x00001b45efb6750a in ?? () Backtrace stopped: Cannot access memory at address 0x1b45eba4f018 (kgdb) --=20 You are receiving this mail because: You are the assignee for the bug.=