[Bug 270667] zfs: size 0 files in /usr/local/etc after pkg upgrade -f after base 2a58b312b62f

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270667

--- Comment #5 from throwaway_vthgwq4@protonmail.com ---
(In reply to throwaway_vthgwq4 from comment #4)

> I'll see if I could bisect it locally (likely not, don't expect much).

Vendor merge + git bisect is a PITA, so instead:

1. Installed
FreeBSD-14.0-CURRENT-amd64-20230323-b5d43972e394-261711-memstick.img on real
hardware (ada(4), 512 sectorsize, no geli, pre openzfs merge).

2. Upgraded to 2a58b312b62f via pkgbase.

3. sysutils/openzfs-kmod built against 1400085 + git bisect:

67a1b0379159 - block cloning, first bad commit (tested via pkg upgrade -f
dbus).

Note, current openzfs tip ac18dc77f370 doesn't build here against 1400085:

[...]
n file included from
/wrkdirs/usr/ports/sysutils/openzfs-kmod/work/zfs-ac18dc77f/module/os/freebsd/zfs/dmu_os.c:39:
/wrkdirs/usr/ports/sysutils/openzfs-kmod/work/zfs-ac18dc77f/include/sys/dmu_objset.h:76:15:
error: field 'os_meta_dnode' with variable sized type 'dnode_phys_t' (aka
'struct dnode_phys') not at the end of a struct or class is a GNU extension
[-Werror,-Wgnu-variable-sized-type-not-at-end]
        dnode_phys_t os_meta_dnode;
                     ^
/wrkdirs/usr/ports/sysutils/openzfs-kmod/work/zfs-ac18dc77f/include/sys/dmu_objset.h:85:15:
error: field 'os_userused_dnode' with variable sized type 'dnode_phys_t' (aka
'struct dnode_phys') not at the end of a struct or class is a GNU extension
[-Werror,-Wgnu-variable-sized-type-not-at-end]
        dnode_phys_t os_userused_dnode;
                     ^
/wrkdirs/usr/ports/sysutils/openzfs-kmod/work/zfs-ac18dc77f/include/sys/dmu_objset.h:86:15:
error: field 'os_groupused_dnode' with variable sized type 'dnode_phys_t' (aka
'struct dnode_phys') not at the end of a struct or class is a GNU extension
[-Werror,-Wgnu-variable-sized-type-not-at-end]
        dnode_phys_t os_groupused_dnode;
                     ^
/wrkdirs/usr/ports/sysutils/openzfs-kmod/work/zfs-ac18dc77f/include/sys/dmu_objset.h:87:15:
error: field 'os_projectused_dnode' with variable sized type 'dnode_phys_t'
(aka 'struct dnode_phys') not at the end of a struct or class is a GNU
extension [-Werror,-Wgnu-variable-sized-type-not-at-end]
        dnode_phys_t os_projectused_dnode;
                     ^
4 errors generated.
*** Error code 1

Stop.
make[1]: stopped in
/wrkdirs/usr/ports/sysutils/openzfs-kmod/work/zfs-ac18dc77f/module
[...]

Off to OpenZFS maintainers.

-- 
You are receiving this mail because:
You are the assignee for the bug.