From nobody Thu Apr 13 20:15:10 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Py9mb4MR0z44XFL for ; Thu, 13 Apr 2023 20:15:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Py9mb1t0dz3Dh9 for ; Thu, 13 Apr 2023 20:15:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681416911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pWpO7Dvgi22AyfTPcCpmqbObkgDnlCwkB1xKV9Kqa5U=; b=EJrjrjpxadZxT2i0FjzYY07yR2rYiYLVDqpc2yoFaul0mD9mtqakT1ioddzkCt3NoovMZv F4I9CIDZ68gbckQsHceq47ypd5BmmRPb9M6AJ6biNoZEVbIOVpRRBZsgAkUAw8egzrSpvX Xie6UV6h4Jaiiz/1ks6Qfzcx8yhWxigymvrngLGvUj7c58AMUaLW5qmdenBZHxyysq/XLp +DZc1rUog3jF3RZF1m9GUDpvzBG6YJk2NFNh7kd74A90T0KktvY+IsK/k0CPqEJj+yxh/I Nyl6Bri0PU0oeQ6aORLn0QYMesnsqsGYsJNElxDJbqTfHg0v0QUR6aekeDz2Gw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681416911; a=rsa-sha256; cv=none; b=FiEbdn/WZCtWB2SZ3Py5lLTWubewlL9zztkdD/lvZasGsAuMDhB4pxeI2m80CPl/PEvAn7 MJghBdifXY1u6f6z07zS749QU+l8khohqd9eMLVdBsvvy24f/kkEKDXHsYxQiXS2CRQ1jT l4T0y6ezFvzDhIaio9gqHv/nbuCAujxGiAeJflveAquYslkx52xv61TEbP2/qowJ4bGEOj DxkxlCOyyiwCOLTyXnsgCrSfx0XQnoDYhNCvjOTsnToNv9jfruhdL22mQY9EuuGUcYyBE7 nL0fnNFBh6KE6vJFmbsDU6zAI6o8MeeyLm4fAkw/3cZETYsA6MRy9UvWrKBA9g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Py9mb0ryDzwR3 for ; Thu, 13 Apr 2023 20:15:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 33DKFBW3042786 for ; Thu, 13 Apr 2023 20:15:11 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 33DKFBbo042785 for bugs@FreeBSD.org; Thu, 13 Apr 2023 20:15:11 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 270785] Performance and power efficiency regression due to pthread_cond_timedwait() changes Date: Thu, 13 Apr 2023 20:15:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.2-RELEASE X-Bugzilla-Keywords: performance, regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: bllcha013@myuct.ac.za X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270785 --- Comment #4 from bllcha013@myuct.ac.za --- (In reply to Mark Johnston from comment #3) I cloned releng/13.2 and reverted commit e21c77f80c3b1cf2bd0a9f874e15e7a8e49f0dba. Reverting this commit fixes the regression. I also did the dtrace output as asked - thank you for providing the dtrace script. releng/13.2 (standard, same as RELEASE): syscall seconds calls errors __sysctlbyname 0.000650415 6 0 getrusage 0.008321625 116 0 sched_yield 1.287887942 29936 0 _umtx_op 41.138906134 30136 30132 ------------- ------- ------- 42.435766116 60194 30132 dtrace: description 'fbt::do_wait:entry ' matched 1 probe CPU ID FUNCTION:NAME 2 18111 do_wait:entry struct _umtx_time { struct timespec _timeout =3D { time_t tv_sec =3D 0xc2 long tv_nsec =3D 0x2ed64521 } __uint32_t _flags =3D 0x1 __uint32_t _clockid =3D 0x4 } 2 18111 do_wait:entry struct _umtx_time { struct timespec _timeout =3D { time_t tv_sec =3D 0xc2 long tv_nsec =3D 0x2ed7d390 } __uint32_t _flags =3D 0x1 __uint32_t _clockid =3D 0x4 } releng/13.2 (with commit e21c77f80c3b1cf2bd0a9f874e15e7a8e49f0dba reverted): syscall seconds calls errors getrusage 0.003569531 58 0 sched_yield 0.168773634 3781 0 _umtx_op 16.840977734 3873 3873 ------------- ------- ------- 17.013320899 7712 3873 dtrace: description 'fbt::do_wait:entry ' matched 1 probe CPU ID FUNCTION:NAME 4 18111 do_wait:entry struct _umtx_time { struct timespec _timeout =3D { time_t tv_sec =3D 0x6f long tv_nsec =3D 0xba6df4a } __uint32_t _flags =3D 0x1 __uint32_t _clockid =3D 0x4 } 3 18111 do_wait:entry struct _umtx_time { struct timespec _timeout =3D { time_t tv_sec =3D 0x6f long tv_nsec =3D 0x8bb061f } __uint32_t _flags =3D 0x1 __uint32_t _clockid =3D 0x4 } So it seems that reverting the commit fixes the issue. It also helps the Un= iFi Controller as well (although that wasn't impacted as drastically as Minecra= ft). This might be a kernel bug as you mentioned? --=20 You are receiving this mail because: You are the assignee for the bug.=