From nobody Sun Apr 02 17:12:31 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PqLDv626kz43w49 for ; Sun, 2 Apr 2023 17:12:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PqLDv524tz459l for ; Sun, 2 Apr 2023 17:12:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680455551; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JyyBkceh8B2u9SHWE9cDUXi2GE5g+RbqbDad2NhoBrc=; b=d3kB6Mc+B0s5uDANUEid/5GmUs1xG+wBqKu2dnrofsWvCM8reCC81D1IAcePGZHHObOv4G ayQmOQTovFKsE8bIUIDGrReGMzGcJF1mpXDyXJluIhSVpO+RJH+kxVJOfMDHvxdN+UGYF+ FHYF/MuWurdAMzKK6rhK8J9rtoRfWMohNVIomvtAvfmHePPfnS1dC7SPpcawyFzo/vwGRY ZCbwlKjGO49P/dxGDCTnG1/3qdgf3mSOSZJfWZjoOlhJnkRRMiFED/gWIBq/PxGhNtPrbX kHYoG7A2ZZt1uMWYHlqLg39HkOAZ6YLbYICIqH007SYbrH26r3K4UV1HD08LtQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1680455551; a=rsa-sha256; cv=none; b=q7294N04K6laOEkm3ZbsDqL6qXBdLv9LWS43e6nOtYcyNOY4vV9rJceQYC0rVeravit3jw sFEpaDX0bewXsUWr482WjJziccnFjAhU7leHlLfbitqyFxNMwP4jKGHZ0uHpivknmGbbeq 2GjrqCvDIDnRb3+Jtr+5bQ9dqqJL3cMxjlszWXwxM7ITn/kCNNRo+nbWYMFl3yc9H5SCzo Ft3iv93xaQwSYBFcFZQ4YOIVirV/g+NnEFFgNlaj2NhNwqhgqev9fnbFBfuK/uzmYjvGvX WJE2/2GANQMufURPIjWVlWzUfBFk5Vukv76tqCe9JyrqkJwXKPC8AzUmwnf9nA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PqLDv3nG9zPvT for ; Sun, 2 Apr 2023 17:12:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 332HCV83004154 for ; Sun, 2 Apr 2023 17:12:31 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 332HCVX7004153 for bugs@FreeBSD.org; Sun, 2 Apr 2023 17:12:31 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 270417] tcpdump does not capture any packets on lagg(4) interface when choosing receive direction Date: Sun, 02 Apr 2023 17:12:31 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: mfc-stable13? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270417 --- Comment #1 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D5f3d0399e903573e9648385ea6585e54a= f4d573f commit 5f3d0399e903573e9648385ea6585e54af4d573f Author: Zhenlei Huang AuthorDate: 2023-04-02 17:01:51 +0000 Commit: Zhenlei Huang CommitDate: 2023-04-02 17:01:51 +0000 lagg(4): Tap traffic after protocol processing Different lagg protocols have different means and policies to process incoming traffic. For example, for failover protocol, by default received traffi= c is only accepted when they are received through the active port. For lacp proto= col, LACP control messages are tapped off, also traffic will be dropped if they a= re received through the port which is not in collecting state or is not jo= ined to the active aggregator. It confuses if user dump and see inbound traffic= on lagg(4) interfaces but they are actually silently dropped and not passed into the net stack. Tap traffic after protocol processing so that user will have consistent view of the inbound traffic, meanwhile mbuf is set with correct receiving inter= face and bpf(4) will diagnose the right direction of inbound packets. PR: 270417 Reviewed by: melifaro (previous version) MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D39225 sys/net/if_lagg.c | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=