From nobody Sun Sep 18 07:27:49 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MVfXk1CGrz4cD4p for ; Sun, 18 Sep 2022 07:27:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MVfXk09gSz3kvd for ; Sun, 18 Sep 2022 07:27:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MVfXj6Cbxzy4n for ; Sun, 18 Sep 2022 07:27:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 28I7Rnww091948 for ; Sun, 18 Sep 2022 07:27:49 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 28I7Rn5M091947 for bugs@FreeBSD.org; Sun, 18 Sep 2022 07:27:49 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 266477] PF does not obey ICMP rate limits Date: Sun, 18 Sep 2022 07:27:49 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: darius@dons.net.au X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663486070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BuOuZj12IB+f3RGkPcvxPDdrW2oC22a55lf+551SKTg=; b=V0j0bETp+Ea1sGwesLvXRlZwzHYrAuOp7Gg9YTPpbgLZrPH2Xf840mWFgYT9NyARqLcU1V aaV26cJfXje0BcDN4UfPcbJJX7cqJoI0KPn5Lh0n+9VSPYa6JWFKeWYcRCiVY9PU1ei20D De7UsKsuBMP58hyREtG8wQo7ZH9Ucr5nGX0/X+4Zj9K1dfuGMO790gdaM3UUeMBHM1g/5R K77c3KcBvtnW9/zdhjesX38uJTtFUryuY3wf75j/0bKymF6CeMAkYqG/HO6WOA8MfwCF53 hKTPMAccwuIR25rdPHavoEqUuDTUd9MlJw2he0KwPrDdj5Zln8q1Oc7aA13nFQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1663486070; a=rsa-sha256; cv=none; b=w5hvSGAyySDROP0UAI6on7rr74aMe1WpjvqXNfZxbioU72gI0TZpDDFRF/VNkDpPof7r19 wlywkSIKX/tgYIgeWa6J8qsVZEMl+6bZGXOS63romAObbmnAiS8WaQDUdfPrQtgXYCE/YW MIB2j4rIv9FxVx3NwUX+4oxKme99FlZWpi1PKwS9zPpYrIHtHbuIxj6iK2WOLPLR/1Qucg 9uaev3XZxWG/sGEf0259xT4t15G5VmADTrfuzo51MLq2PHrtKm9k6qeDJZsBySONabxYso ufVDlT5b9U8NJemBTIWyp7bsMfLajXzSyKnObXRo4xh1IXjHb7jzXy3fXSpeig== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D266477 Bug ID: 266477 Summary: PF does not obey ICMP rate limits Product: Base System Version: 13.1-RELEASE Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: darius@dons.net.au CC: kp@freebsd.org PF emits ICMP messages for blocked connections (when return is set) but it = does not call the rate limit code (badport_bandlim) and hence will send them at = an unlimited rate. IMO this is a POLA violation. Furthermore the IPv6 stack does not appear to call it either, badport_bandi= lm has BANDLIM_ICMP6_UNREACH but it does not appear to be used. I think it would make more sense to move the rate limiting code into icmp_error/icmp6_error and perhaps also add some per-ICMP type stats expose= d as sysctls. --=20 You are receiving this mail because: You are the assignee for the bug.=