From nobody Tue Nov 29 16:19:29 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NM6wx4f67z4jBYW for ; Tue, 29 Nov 2022 16:19:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NM6wx2dPYz4QPs for ; Tue, 29 Nov 2022 16:19:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1669738769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fqZVyA6/swTEs0ds0s2boMwpz4cV1orl5Yx0B6mFmb4=; b=oYB12vrrh8DiThJnLv5RljNnQ6/TIlx3+NJdA6lrsW31Mgt6RzKEjxxLOxZbXeBwcpW5fo 7Ze/M5zsR4dIaeVP8irHr6KXpjpkhDL9j/kW1hyfignOJpqKgm8n49aqLqaARfZ6StFnic GMRMVN+UPZPEWttK0qC4mNd5vLbo7eFG//jPodhgy+hZAp2uEb2xuLVheK45soXMkXHXV6 srjA6qVf5H63T1l5iFT+hiOiTF6/G7YcYKOQvSLntySF/rP+ORIyEqFJrGrzK67+jxin5D jDYyCztvBvldfaZVTngcOBX/zRpgKHQeDPZOZUAvrHAaS5M2z3+Dx5pmITpcEg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1669738769; a=rsa-sha256; cv=none; b=nGjtMMs8QGpGq8s7LXtc7psfytekqOFIryzCUJ0PMuADoyR0rR6WbCYCKY14LoyFa1HGMy /SNC83sdwmwNU/cMHLhh91XyZsJfJHsZddwrHcxevCJrvLS5KCyTOVr9AF6bQLdUsbUfLe OCRQ8o+ZqeHUDJeSRMnGotWsQK33SCW57ghHCUPkOCOJ26rMZx+eLjnWpT7ffccMiTGcpK X282yX9p9reCFzi/nliYOus869bfjbtPxoEe8dDOKj4vMi6p/XMq/JUbgyNz3lspOlyCzT 2sIpVOvzlSZ4WnW6g5eVZKHv25fhFFOW84olJetW0dMo5ANq6wKFZx8kwfQ/2g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NM6wx1gyrzNZy for ; Tue, 29 Nov 2022 16:19:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 2ATGJTsJ085355 for ; Tue, 29 Nov 2022 16:19:29 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 2ATGJT6c085354 for bugs@FreeBSD.org; Tue, 29 Nov 2022 16:19:29 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 268059] client can cause kadmind's kadm5_s_create_principal() to use uninitialized pointers Date: Tue, 29 Nov 2022 16:19:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rtm@lcs.mit.edu X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.mimetype attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D268059 Bug ID: 268059 Summary: client can cause kadmind's kadm5_s_create_principal() to use uninitialized pointers Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: rtm@lcs.mit.edu Attachment #238422 text/plain mime type: Created attachment 238422 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D238422&action= =3Dedit client that causes kadmind to use uninitialized pointers If the client sends kadmind a kadm_create with a zero mask, kadm5_s_create_principal()'s call to create_principal(...,&ent,...) returns error KADM5_BAD_MASK before zeroing ent, and in response to the error kadm5_s_create_principal() calls hdb_free_entry(...,&ent) which reads (and perhaps writes and calls) uninitialized pointers in ent. I've attached a demo, which requires kinit and perhaps permissions in /var/heimdal/kadmind.acl. # cc kadmind18a.c -lkrb5 # /usr/libexec/kadmind --debug & # ./a.out #0 0x0000000040173506 in hdb_free_entry (context=3D,=20 ent=3D0x3fffffe608) at /usr/rtm/symbsd/src/crypto/heimdal/lib/hdb/hdb.c= :179 #1 0x00000000401533fc in kadm5_s_create_principal (server_handle=3D0x40b30= 4c0,=20 princ=3D, mask=3D0, password=3D0x40b42060 "") at /usr/rtm/symbsd/src/crypto/heimdal/lib/kadm5/create_s.c:191 #2 0x000000000010a70c in kadmind_dispatch (kadm_handlep=3D0x40b304c0,=20 initial=3D0, in=3D0x3fffffe790, out=3D0x3fffffe780) at /usr/rtm/symbsd/src/crypto/heimdal/kadmin/server.c:149 #3 v5_loop (contextp=3D0x40aeae10, fd=3D5, ac=3D,=20 initial=3D, kadm_handlep=3D) at /usr/rtm/symbsd/src/crypto/heimdal/kadmin/server.c:477 #4 handle_v5 (contextp=3D0x40aeae10, keytab=3D, fd=3D) at /usr/rtm/symbsd/src/crypto/heimdal/kadmin/server.c:556 #5 kadmind_loop (contextp=3D0x40aeae10, keytab=3D,=20 sock=3D) at /usr/rtm/symbsd/src/crypto/heimdal/kadmin/server.c:584 #6 0x000000000010ab30 in main (argc=3D, argv=3D) at /usr/rtm/symbsd/src/crypto/heimdal/kadmin/kadmind.c:202 --=20 You are receiving this mail because: You are the assignee for the bug.=