From nobody Thu Nov 03 20:56:03 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N3GJ41l6kz4gkLN for ; Thu, 3 Nov 2022 20:56:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4N3GJ33HChz3LD2 for ; Thu, 3 Nov 2022 20:56:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4N3GJ32FRhzqh3 for ; Thu, 3 Nov 2022 20:56:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 2A3Ku3rY090565 for ; Thu, 3 Nov 2022 20:56:03 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 2A3Ku3a1090564 for bugs@FreeBSD.org; Thu, 3 Nov 2022 20:56:03 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 267533] Zfs Multi-Modifier Protection trigger an activity check even if it is disabled Date: Thu, 03 Nov 2022 20:56:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.3-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1667508963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YtQCeKzU5tN6uxlJWTlUpyBTo8F6HAF50fbQEmfB+9A=; b=xgTuc9zFn+5sJbpu8T78MsEikl9KJdb1s81242GpK85g1JcGPOR/4pRWcAzlrW1sLg1i2q 56x84NXBw+u7QlwnjGz5KGPz3v9hwfYYftltGFMKTOogLQGylzktbX18Ww5bmdPj/kJAm0 /Pdf5N2rh6ENTEvtrCOGQA2xpj4QUeCxo3uj/FxihWA1Fi8hD7XZ0Cg+VwVDMygdBnLB7k tzINItcTKZanwIs4j7nLISyjPWAnyQNu3NuC1PnbU/cD23iY6WUJMn4xznJ7szYXAIvyX1 DEImQfLbEZJ5CUD05lswLLhJi0zNEkK/yQhqkAuMYqw6hNU88HAVGYGXDHD+NQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1667508963; a=rsa-sha256; cv=none; b=FJxFLFyM2YN3bWDOoglpjXGiQlQ8J1QOCgXPbFZkDakK/gejZ6/rcZCeMs7JiMTMXPsdaP 3qwFBrQH7k/EQsP0PedjtyJD/noUGDIMLDVFaoNQI6GJ8zIdqHD3QQm0+vJ/VS1drDPzyQ RQL0x6s7bDWfm6Pwcp9ZcfSKO6bZKS0SPsvkH3irl7atAKsNTNJZ0pjganfZxtHwmcsl4S 4wiknmnX9B7TFqNBB1w5cGdkBOhwHfKtvm+8qOFAke6HGCkFp1ibKWGkTkg6u/S4PfiZcS U3xN3J2U+0BTZawjYcX28tPo1/VlhhNWykmj8tju/eLiRUYwetFM0f4PVtxcuw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D267533 --- Comment #3 from Mark Johnston --- (In reply to Mathieu Schmitt from comment #2) From what I can see, "MMP is disabled" means that the MMP timeout is 0. See the comment above the definition of ub_mmp_delay: 956 /* Maybe missing in uberblocks we read, but always written */ 957 uint64_t ub_mmp_magic; 958 /* 959 * If ub_mmp_delay =3D=3D 0 and ub_mmp_magic is valid, MMP is = off. 960 * Otherwise, nanosec since last MMP write. 961 */ 962 uint64_t ub_mmp_delay; When ub_mmp_magic is zero, i.e., we are upgrading from a version without MM= P, we use a default timeout. The "activity check", just reads an uberblock several times with a pause in between and verifies that the txg recorded in the uberblock does not increa= se.=20 If it increases, then something else is writing to the pool, and it must no= t be imported. In your case, the txg changed, so something [else] is writing to the pool, = so the check fails. The fact that ub_mmp_magic =3D=3D 0 is not relevant; the = txg should not be changing. Maybe it is indeed a kernel bug, somehow, but I believe the patch just hides it. From what I can see, the "multihost" property mainly controls whether ZFS w= ill periodically write to the pool, to increase the chance that "zpool import" notices that the pool is active. --=20 You are receiving this mail because: You are the assignee for the bug.=