From nobody Mon May 23 01:36:38 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id B96FD1B48922 for ; Mon, 23 May 2022 01:36:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4L60Ky2WYdz3JYW for ; Mon, 23 May 2022 01:36:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 3336A26980 for ; Mon, 23 May 2022 01:36:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 24N1achJ073525 for ; Mon, 23 May 2022 01:36:38 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 24N1acSm073524 for bugs@FreeBSD.org; Mon, 23 May 2022 01:36:38 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 264166] mount_msdosfs refuses to mount glabel label. Date: Mon, 23 May 2022 01:36:38 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: t_uemura@macome.co.jp X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1653269798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pUgp47HmNQlA6lowZ1SJ4laBEocaiDxYbu5+zI5s5RM=; b=U36h49nK2yNEykrqT4Yj9zFiEfILxzdId+cIFoEnxzkiBdz8xRo9AoTAeLe9K5MxcXWpn0 R1pBfbxiwKhk6DhFTcg21oWMuK9GVm56RUyhToDm/9FjBMdopUAvfHjMG/nyliblYZd7i4 4lNq4ajRx+bv1FCj4h6SqJ/xz+ShaQTfTHdl2rLbJaAvFcZpYOFL8yMNiq0sXjAwUUIKLy oykYVidAH+NtSKOnf2nZU0wl3rkDCrwjPRRuuUPMKjRG13HuLQi5S8D752bZfijYaFrXUi wQL+M7s2Bv+gAu+eOMDmeFpAENrLCG95yaCmYviNLZpFrxAPUKDJX4GpoLQASQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1653269798; a=rsa-sha256; cv=none; b=R+kT1Xr06qOrxuQkg3IBax6SKznz53M/ivY/HpBoSXdE/va9UdmHz80qy2URqa1gchoTYR H+yl+a17/9zfk0mlWOYpkpdL5JQv4F0PwtsJBjTSDok5waDN677ryKyArCI2ASGD0HnyRC 3/r+J4Z5G/evW6fnFe/aKNHiXBnOcW2m7J276DQWpL8mnXz/Xh+ZPcGH25/BjdGCfj5TBx dj1coeHYQC9JRgRmxJ0Sl/R/L/R/OmK4Olx9JfEDF0HAYdohZgvs7iLe6E/+XRW7MkTWNB KmZmKpPC7fcU/QnLCc1e9b1r1S3x6s9Me3Q+Jkyw/SM+RoCoAgNZIjSS3HqGJA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D264166 Bug ID: 264166 Summary: mount_msdosfs refuses to mount glabel label. Product: Base System Version: 13.1-STABLE Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: t_uemura@macome.co.jp There is a regression caused by the commit c5c1537dc7ffd27066d035b8e236d3dcb548a3c8; msdosfs: sanity check sector count from BPB, by Mr. Konstantin Belousov, which made mount_msdosfs to not accept glabel label, even though the bare device node (such as da0s1) of the same = disk can be mounted and accessed correctly. With the mentioned commit applied, as shown below, label couldn't be mounted though the corresponding raw device da0s1 was handled as expected. root@da320:~# glabel status | grep label/ label/MACOME_CONFIG N/A da0s1 root@da320:~# ls -la /dev/label/MACOME_CONFIG crw-r----- 1 root operator 0x73 May 22 20:54 /dev/label/MACOME_CONFIG root@da320:~# gpart show da0 =3D> 63 3919809 da0 MBR (1.9G) 63 3919809 1 fat32lba (1.9G) root@da320:~# mount -rt msdosfs /dev/da0s1 /mnt root@da320:~# echo $? 0 root@da320:~# umount /mnt root@da320:~# mount -rt msdosfs /dev/label/MACOME_CONFIG /mnt mount_msdosfs: /dev/label/MACOME_CONFIG: Invalid argument root@da320:~# echo $? 1 Backed out the commit, and the issue was fixed. root@da320:~# mount -rt msdosfs /dev/da0s1 /mnt root@da320:~# echo $? 0 root@da320:~# umount /mnt root@da320:~# mount -rt msdosfs /dev/label/MACOME_CONFIG /mnt root@da320:~# echo $? 0 root@da320:~# umount /mnt With another USB stick (with the same label), the same problem happened if = the commit was applied. root@da320:~# glabel status | grep label/ label/MACOME_CONFIG N/A da0 root@da320:~# ls -la /dev/label/MACOME_CONFIG crw-r----- 1 root operator 0x7b May 23 09:56 /dev/label/MACOME_CONFIG root@da320:~# gpart show da0 gpart: No such geom: da0. root@da320:~# mount -rt msdosfs /dev/da0 /mnt root@da320:~# echo $? 0 root@da320:~# umount /mnt root@da320:~# mount -rt msdosfs /dev/label/MACOME_CONFIG /mnt mount_msdosfs: /dev/label/MACOME_CONFIG: Invalid argument root@da320:~# echo $? 1 And fixed when backed out. root@da320:~# mount -rt msdosfs /dev/da0s1 /mnt root@da320:~# echo $? 0 root@da320:~# umount /mnt root@da320:~# mount -rt msdosfs /dev/label/MACOME_CONFIG /mnt root@da320:~# echo $? 0 root@da320:~# umount /mnt --=20 You are receiving this mail because: You are the assignee for the bug.=