[Bug 262896] /usr/sbin/fstyp is not able to detect FAT filesystem on Raspberry Pi Pico

From: <bugzilla-noreply_at_freebsd.org>
Date: Tue, 29 Mar 2022 21:34:18 UTC

--- Comment #3 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:


commit 868c1b8431f297ade8deba5baf903f73cf5e11c6
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2022-03-28 21:03:10 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2022-03-29 21:33:15 +0000

    fstyp: detect Raspberry Pi Pico boot filesystem as FAT

    fstyp looks for a 0x55 0xAA signature at offset 510, but this is not
    required by specifications and is not proivded by the Raspberry Pi Nano

    We should really remove the signature check and implement a more
    comprehensive BPB validation instead, but it will require more
    investigation and testing.  For now just add a special case for the
    Raspberry Pi Nano bootloader, to avoid introducing regressions or new
    false positives.

    PR:             262896
    Reviewed by:    delphij
    MFC after:      3 days
    Sponsored by:   The FreeBSD Foundation
    Differential Revision:  https://reviews.freebsd.org/D34699

 usr.sbin/fstyp/msdosfs.c | 21 +++++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)

You are receiving this mail because:
You are the assignee for the bug.