[Bug 262515] Missing filecaps_free() in many places

From: <bugzilla-noreply_at_freebsd.org>
Date: Thu, 24 Mar 2022 19:51:27 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262515

--- Comment #4 from Mateusz Guzik <mjg@FreeBSD.org> ---
I agree it should be on demand, but I have further notes.

1. fd-related code in namei_setup needs to be factored away to kern_descrip.c.

2. if the caller does not care to look at caps, we can make a copy without
allocating anything (and subsequently without having to free anything). as
shown in the reproducer, the only part which requires malloc is ioctl handling,
but ioctls are not inspected in the lookup itself.

3. instead of direct filecaps_free perhaps NDFREE_CAPS or similar should be
provided

I'll sleep on it and probably hack it up over the weekend. It will be mfcable.

-- 
You are receiving this mail because:
You are the assignee for the bug.