From nobody Sun Mar 20 15:06:02 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 11A911A196D7 for ; Sun, 20 Mar 2022 15:06:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KM1KQ2qx2z3McC for ; Sun, 20 Mar 2022 15:06:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 3697C1430 for ; Sun, 20 Mar 2022 15:06:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 22KF62g8023612 for ; Sun, 20 Mar 2022 15:06:02 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 22KF62IH023611 for bugs@FreeBSD.org; Sun, 20 Mar 2022 15:06:02 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 262685] periodic 223.backup-zfs saving ever changing properties, unuseful daily e-mails Date: Sun, 20 Mar 2022 15:06:02 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: misc X-Bugzilla-Version: 12.3-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: 000.fbsd@quip.cz X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1647788762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AnMRMIsAE3RQ0WL9fTsyZm++N4/+wDV8tYtRgA12UYA=; b=xj0Fl3gtNWV00Sxe3hoPUAEZ08GDJVVekbB1vOqD6A1zZBKSSMe//Deb3qdxFkvAuF6u2r jKnlylTIt/Xx/BBYSuMmTyJx9S6sVPL0pn3W15cT7u+qhB3lZ1l+lXByNsd8WenisPlrZr AT/wXK0PrSvFWBTOj9WdNlKnBT6/fqBTExEcu/fd30sZIzQBlouVuEKHidkLzANSNvcvln 753M95Pow/hAzoNfX+SBsfOt1ZbhSBRDuY3MgCAk6ORcH/Ir49ySspuZ0UOopivHl5boGU zoZj9SdI707djel1SGuX4yHkzPGX1gtgLkG96H4M7rFmhIsmkhsqNYj5wv1vCA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1647788762; a=rsa-sha256; cv=none; b=GGjGtsiZGo5NS085fNr8nMCFojW/WorHb78DWMBcEj3EPdpBTm6Hl1F2mAiJtAIT5efqKk gFCkLu61ys5ermYC+G73n761MGRHidxiLuc19d0hxLtLjN0xgVHc6+ms/StdH5ZPkD4B6q PXDO09Jd80K2PLPtbTZjV1XcHz6L4YZ/P4CDlW0Vre0whSUtPZwi5Mevo8XvApfoKRlnRa DPxTK+vIhLz9Xpt9aM+PRvhsPHC2oVPKVNr0Q7phL+0uSuiwBK3H4MV0ab8J2sk3ohkzFD NLcxqTy48J8VlsbRkgv+sbEk979UbzqbHBZCnk8bFhhRwp7fc7DFTr/E4ikh+Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D262685 Bug ID: 262685 Summary: periodic 223.backup-zfs saving ever changing properties, unuseful daily e-mails Product: Base System Version: 12.3-RELEASE Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: misc Assignee: bugs@FreeBSD.org Reporter: 000.fbsd@quip.cz The script /etc/periodic/daily/223.backup-zfs should save informations about zpool and zfs layout and some useful properties. These informations should = be useful for recreating the pool layout after some disaster (machine parseabl= e?). I am the author of the original version from the PR 86388 and this was my intention. There should not be any statistical information (compress ratio, space usage etc.) These commands were used for this in the original 223.backup-zfs zpool list -vp zfs list -p -H -o name,mountpoint zfs get -H -p -t filesystem,volume all | grep -E -v "available|compressratio|logicalreferenced|logicalused|refcompressratio|ref= erenced|used|usedbychildren|usedbydataset|written"=20 zpool get -H -p all | grep -E -v "capacity|dedupratio|free|allocated|fragmentation" They were changed in committed version to simple zpool list zfs list=20 zfs get zpool get But this breaks some things. Current and previous backup files are compared= and differencies are being e-mailed. This committed version will see difference= s in things like compress ratio, space usage and other things which should not be included in the backed up informations. Then this unuseful informations are being sent to the user just because the= re is difference in disk space useage Backup of ZFS information for all imported pools 33,34c33,34 < sys/usr 10.0M 12.3G 88K none < sys/usr/home 8.88M 12.3G 1.48M /usr/home --- > sys/usr 10.1M 12.3G 88K none > sys/usr/home 8.89M 12.3G 1.48M /usr/home 42c42 < sys/var/tmp 3.38M 12.3G 148K /var/tmp --- > sys/var/tmp 3.38M 12.3G 140K /var/tmp 84c84 < tank0/vol0/web 265M 9.80T 9.54M /vol0/web --- > tank0/vol0/web 265M 9.80T 9.47M /vol0/web Also I don't see dumping properties for snapshots much useful but it can be painfully slow on systems with a lot of snapshots, that's why my original version had zfs get -H -p -t filesystem,volume all. I see this can be changed in /etc/periodic.conf with daily_backup_zfs_get_f= lags but I think there should be more sane defaults. I am using the original version from 2017 but now, after upgrading FreeBSD = to version with 223.backup-zfs shipped in the base I am seeing long list of changes in each daily e-mail. I really would like to talk to somebody who is in charge for periodic scrip= ts and find a way to make it better for all users. I can provide patches if we agree on what and how should be done. --=20 You are receiving this mail because: You are the assignee for the bug.=