From nobody Fri Mar 18 16:54:41 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id B01771A1E3E5 for ; Fri, 18 Mar 2022 16:54:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KKqqj2tGvz4g84 for ; Fri, 18 Mar 2022 16:54:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 437A422B74 for ; Fri, 18 Mar 2022 16:54:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 22IGsfOL011298 for ; Fri, 18 Mar 2022 16:54:41 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 22IGsfN2011297 for bugs@FreeBSD.org; Fri, 18 Mar 2022 16:54:41 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 262638] overly strict check of hpet region size Date: Fri, 18 Mar 2022 16:54:41 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1647622481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OXxoEUBoZa5iAwdkLTM00A6UFUujzAQ7v9NGp5ziYwM=; b=Qv7buYPrkXQUJnYFngJ9VhjTCBs3lG8N30DJfpM2ceew9zUnSM+v5w+6OBhbTgrUhKlZdk GV9Z4X5YsVZykxqOxssnNmPjlBs1UBQeY9UYcSSxKcXEcvpIB4Frt+jci0r/6rXzWLsgkV Y9UDS8EvfVEee9deBteueqWW+Zydca0i7NBOu0XMVCYb0C0W2kvDQ8Yp/t3uxm4pN4oSNJ zvEX3sTjTXeZ4lMoN3MnflNt5105TCjbgiBJfPAZwLwx35EXirvfYhsws5/qgTFQhiULAh AK6Fd3OdbTiqGpJYIfMnht4/SXZugIArvQe5ghIcheO1ZMn77oGwGl4QV0OgWg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1647622481; a=rsa-sha256; cv=none; b=pURPn/LDz58hZeMDgZPEzSAeYqggFfI4Fu/z0Vnk0EiKfhunHxi4cj+ddgwcemvU6H4LlA XaKBCtM4JtobuwW8ndFL05W9o6jMPhKBdpLkWm5k2MJqospp/plythfF1f91Txk3F+15hy mT9JWtz0oGXx7h6QiaJEpkjocbC5m3EfK85eZLFKkND5wXtXBLY5DpGImXu81nev4TMd2o yDILob2uOPePvf1O8pSCqhn2OFJ/bRKNPtkVagvaF0+zQSwaKpe5mhM3/jRCx4GvAFDu2n uPWB4t4hmfJd5sB4H7uL/AU8AhCSBWthjF+3X0G5klox1wt33oTZkcLXBC3B4A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D262638 Mark Johnston changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Open CC| |markj@FreeBSD.org --- Comment #3 from Mark Johnston --- The value of 1024 comes directly from the Intel specification, see section = 2.1: https://www.intel.com/content/dam/www/public/us/en/documents/technical-spec= ifications/software-developers-hpet-spec-1-0a.pdf Some AMD documentation for 16h processors suggests that only three timers a= re available, and the MMIO space for HPET registers is indeed only 512 bytes in size: https://www.amd.com/system/files/TechDocs/52740_16h_Models_30h-3Fh_BKDG.pdf Changing the value of HPET_MEM_WIDTH doesn't seem like the right solution: hpet_identify() uses that constant to initialize the memory resource for the hpet driver if it can't get the resource size from acpi. We could instead modify the check in hpet_attach() to first verify that the resource is large enough to read the capabilities register, then check it again once we have = the number of timers. --=20 You are receiving this mail because: You are the assignee for the bug.=