From nobody Wed Mar 16 18:39:40 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id F31501A2C7BB for ; Wed, 16 Mar 2022 18:39:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KJfFm4v4Nz4s03 for ; Wed, 16 Mar 2022 18:39:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 87E8B1B8A1 for ; Wed, 16 Mar 2022 18:39:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 22GIdesM006147 for ; Wed, 16 Mar 2022 18:39:40 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 22GIde40006146 for bugs@FreeBSD.org; Wed, 16 Mar 2022 18:39:40 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 262580] fsck fails system startup if USB disk is not yet configured Date: Wed, 16 Mar 2022 18:39:40 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: misc X-Bugzilla-Version: 13.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1647455980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rlUuQtTl1B+VBx2JGI/PF32NZRzHUX84ZUrOgsx7Fd0=; b=D/gxK2YDDJ/Oi/CIpOykPQhdiftaWA74Lu5pcVO/mZJx42cdPRoKq5r6n5NaeJNfLl8uWN mvMJztp4nUpKVHM+frN8oulPjEWbao79TMNi1Yqr2JKkbXUo5GcK9TYkUVLZ5+ghcYYiXh C6NYb8x39H4z32YVVpxBFftcYyp/MFc8lIeC/4Nxm0RFYXQ6iAV7G+aUZ8F4IscS75QOm5 slrMlIK8xDhx0H+JccEyhug5T+fTTiruS2hTzDN8qtXuKel/mphUOxsQFajoFru0LQkXS3 hsUw7lRI0TvZEBeJc6BKZd487laSI8nmC5iGKpSeKT6rH1P7MM4oRwkpb+NXZA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1647455980; a=rsa-sha256; cv=none; b=i6gMRnjAlomebN68vq+gin/3QVyTKMKd+5fp+0FGe1JZjwDaGsgyouTMj36lC1OC4NsqW5 GVA0Up6fchXn5yc138DRD0fUIES/YG8C1OYBu9pzuaTCPMnMx79OtAfEVODd2ZFxjwH8Hq CSM54s/oBli8GWXsvtHdKjJVHWoRc7YHRpvNRH8AofFwrn5051EGDWfLQGbWW31Rsg9mpk /qrc3hXcSvsD2ka8BYRknkwonNBM5TceI0haTAn7Qkm0X/LdSvcP/1xiIRhDBmPCPUr/W9 djX3t7iM5VyHAHcryXh/WrCIdS4B8AHwb7+NaJhsV22T1FpyGln1AMCG/7haBw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D262580 --- Comment #2 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D2983ec0a87a18943564548c5c00c879c8= db83edf commit 2983ec0a87a18943564548c5c00c879c8db83edf Author: Kirk McKusick AuthorDate: 2022-03-16 18:37:15 +0000 Commit: Kirk McKusick CommitDate: 2022-03-16 18:37:15 +0000 Ensure that fsck(8) / fsck_ffs(8) produces the correct exit code for missing devices. The fsck_ffs(8) utility uses its internal function openfilesys() when opening a disk to be checked. This change avoids the use of pfatal() in openfilesys() which always exits with failure (exit value 8) so that the caller can choose the correct exit value. In the case of a non-existent device it should exit with value 3 which allows the startup system to wait for drives (such as those attached by USB) to come online. Reported by: karels Tested by: karels PR: 262580 MFC after: 3 days sbin/fsck_ffs/setup.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=