From nobody Tue Mar 15 18:16:35 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 1FC3F1A25DB4 for ; Tue, 15 Mar 2022 18:16:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KJ1nd0WSZz590M for ; Tue, 15 Mar 2022 18:16:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 80E41266C7 for ; Tue, 15 Mar 2022 18:16:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 22FIGawm000886 for ; Tue, 15 Mar 2022 18:16:36 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 22FIGa98000885 for bugs@FreeBSD.org; Tue, 15 Mar 2022 18:16:36 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 261446] freebsd-update should not create boot environment when it's not making changes to the boot environment Date: Tue, 15 Mar 2022 18:16:35 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1647368197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gjje32FlkqYMP0LWGDJ+YRA9enNsYG7PF9u9Qqw7UMY=; b=Mr3CjIyCRfaI9PUAs6Az1Ob1nF7fFMGmhMgfvUyuvNbpkPCMXT/BppW5jUccfxiipMkVqn d5V1+yld35ctNMdYUM2EDXe+1vXn1CEBtgJhnR/qXQx7HEdOO8I86QMMxvhmyXeo87rJS8 SZ3JSKvAMdb0Ncr6V+oEbJJ0lX3u6bTVjyfrc8fJ1s2Dbcv19PMrv6LoTR7gcrtRKFk7yy f9xFxiNYukcFpqnLhOokddmHejcRtZIFKqg8eIQRb8AfDSgXKbkVmLMAA3wlCBmOrU1XM2 17Lj9ignTFQ2r/ThAt7dSKikhNR2qKDRaz9B31MzRpyIM7rreu4YxQ/FjNFTwA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1647368197; a=rsa-sha256; cv=none; b=oUhx4MGtYZDXOUgw3Wt03VRs+tXNR+w2MS5vd5QDoTf2wBzUbL9kuOC0z+CAFrtdBhGT6Z GoYrQe4UaSAPrQYLKAzOIrotx/pjb1UTqeaTD0CnFKf72t8BbDTumBo6aYGx9jHVHo91F1 cKBuwgkntKAlDzTdef9M+Vv7fFSnFFvN+Z+4yYWK3CjZLdwOijiofBzqmh86R/um7d/5Zh nPRq1u424emnz7J97ihK/wvfDCBl65FAMMnvt0P6QuDB5Uzm/TDvZ6nsP5AxFiR7r7wgqM 97n2n4+qm8Z5wHfaLGcrNIFDIWGmnT7RX1fDsno+1gCvr0oBBaUJFZiB7Jv3DA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261446 --- Comment #9 from commit-hook@FreeBSD.org --- A commit in branch releng/12.3 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Df0df8a13116dca6ac42334d23430160fb= eaf6c09 commit f0df8a13116dca6ac42334d23430160fbeaf6c09 Author: Kyle Evans AuthorDate: 2022-02-12 21:36:24 +0000 Commit: Mark Johnston CommitDate: 2022-03-15 17:46:50 +0000 freebsd-update: improve BE creation feature This addresses one nit and one bug in the BE creation feature of freebsd-update: The nit addressed is that it currently only names the BEs after the userland version, but the kernel version may be higher. After this change, we request both and pass them through sort(1) to choose the highest. This is especially helpful if a freebsd-update patch touched one but not the other. The bug fixed is that roots updated that are not located at '/', e.g., by using -b or -j, will no longer create boot environments automatically. There's a very low chance these will actually change the BE in any meaningful way, anyways. It could make sense in the future to allow an argument-override to create the BE anyways if someone comes up with a non-standard setup, e.g., where a jail is an important part of their boot environment on an appliance or some such setup. Half of this patch is submitted by delphij@, the other half kevans@. PR: 261446 (cherry picked from commit e01e8f911b935eabcc35b4d121951e4e21042ee5) (cherry picked from commit 35d33d408213d20c63d60c0dfcdf77b2b36f5eee) Approved by: so Security: FreeBSD-EN-22:09.freebsd-update usr.sbin/freebsd-update/freebsd-update.sh | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=