From nobody Mon Mar 07 16:26:49 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 50CBF1A00D7B for ; Mon, 7 Mar 2022 16:26:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KC3kd4S2tz4bcQ for ; Mon, 7 Mar 2022 16:26:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 568D238B4 for ; Mon, 7 Mar 2022 16:26:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 227GQnj3098431 for ; Mon, 7 Mar 2022 16:26:49 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 227GQnmC098430 for bugs@FreeBSD.org; Mon, 7 Mar 2022 16:26:49 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 261751] vt mouse pointer background display bug Date: Mon, 07 Mar 2022 16:26:49 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: vt X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646670409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hiklhJwUgH8Ds3ZbDhpZjctNXsYF1VbPYzFBS+oEgqY=; b=i8mdBdF1snHr4akSo/WyduYHKrVJd32w1A9pl12pIbOpFsI3vWwCJoNJjpO/qxpqRNqLvY 76lIHfw1Q3xg4enZHznlp765sIVLiXgIziHHpAp2LZwE8ORwNXYWv676EUTPcLy46vTj+c bDTwwX+PEw0XT0wSqTRPDG76CpQXA/Kh+quDJdo0f7KD7lEsI5lBr48a+fAbt2Gna0fRYO j80UXK5uiWIvp2RzBTsDwLbiaO8uwefDcPTeoeH9jUYIVg3D5Ah7IhQ59sD8PvRzUcgZFP RK6XUmkXQhnhv1jeb0Mya3JQJvy2qWxy8pQWa5tcze9XNdXj0rAHEa6uNz3rrQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1646670409; a=rsa-sha256; cv=none; b=MqWkpQgmJ7ddV7CPBoD+2GasH2Kgdvph+Z5FLV1W/GMfyoHySH1fQOzWdBQpAZuuN92uR5 he29Nl5p4aTjaTtyWWhHvdHxW3sX/fPMfs7wuCO6WAXEDg1SYl/Qe5IuhXy8k7VXxD1ae0 XIhaHfsoVGS9zkBexTbJZGi5UQbAj27b1sFVygu3JpF8ETJc+iaskGVk4w/PH3736UWZ9l cGjWX3rF3MVvMgfJljKi5vpCx0L4ZGjMiPH5c4fxxrEXnEYuDOas3C4pdWH8rHmwbo2kWa VyESo5XSC7gKSP0/FEh616i0YiDR5h+hYoEnRbWVEueBHuHghOdVxSAVGdx3WQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261751 --- Comment #9 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Deb40c0f2f2ce5d83707bef2f9c8259312= da852d1 commit eb40c0f2f2ce5d83707bef2f9c8259312da852d1 Author: Ed Maste AuthorDate: 2022-03-02 16:40:00 +0000 Commit: Ed Maste CommitDate: 2022-03-07 16:25:21 +0000 vt_vga: fix colour in pixel blocks with more than 4 colours VGA hardware provides many different graphics and data access modes, each with different capabilities and limitations. VGA vt(4) graphics mode operates on blocks of pixels at a time. When a given pixel block contains only two colours the vt_vga driver uses write mode 3. When the block contains more than two colours it uses write mode 0. This is done because two-colour write mode 3 is much more efficient. In practice write mode 3 is used most of the time, as there is often a single foreground colour and single background colour across the entire console. One common exception requiring the use of mode 0 is when the mouse cursor is drawn over a background other than black, as we need black and white for the cursor in addition to the background colour. VGA's default 16-colour palette provides the same set of colours as the system console, but in a different order. Previously we configured a non-default VGA palette that had the same colours at the same indexes. However, this caused anything drawn before the kernel started (drawn by the loader, for instance) to change colours once the kernel configured the new, non-default palette. In 5e251aec8636 we switched to leaving the default VGA palette in place, translating console colour indexes to VGA colour indexes as necessary. This translation was missed for the write mode 0 case for pixel blocks with more than two colours. PR: 261751 Reviewed by: adrian MFC after: 1 week Fixes: 5e251aec8636 ("vt(4): Use default VGA palette") Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D34412 (cherry picked from commit f266082f113a6a110c28034c64693c2cc216fd9d) sys/dev/vt/hw/vga/vt_vga.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.=