From nobody Fri Jun 17 18:49:47 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id D694F83E03E for ; Fri, 17 Jun 2022 18:49:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LPp4W4zXvz4ry0 for ; Fri, 17 Jun 2022 18:49:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 88A2824A69 for ; Fri, 17 Jun 2022 18:49:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 25HInlIk002212 for ; Fri, 17 Jun 2022 18:49:47 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 25HInlEJ002211 for bugs@FreeBSD.org; Fri, 17 Jun 2022 18:49:47 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 264723] the KERN_LOCKF sysctl returns kl_file_fsid that doesn't match st_dev from stat() Date: Fri, 17 Jun 2022 18:49:47 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: damjan.jov@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1655491787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pQ7jS8i6TCHJtvGWApsHjKe8GVtSWoCyRDjZ7oknnaA=; b=U24xiV75JGY+glYt1Q03UsbGxy94dVOKaJDg4ETrI0tZ8x6QF6ijSJyRh3zinxdTL/b+w0 cXqU/1zIlu9LF7djR2WQzrbKt70W1/DMMAW5JTOcmcl/THUeKAioE2ehMYdGIBZ5AmglkV wv44leAiFBBhzLFU6NDXEiSq+fzjCQBBS96niafi8gqFSDueFVo7uGyy5gVqZhFCpRr68b uzq5KnK1x0riuYBMhPBAHyD1YsxzyxS/5xXVj5zLlmsnMqLnpBM2OIiF5qyjn4fJn17qTs +bCh+xpwEtHrLn46CDnhPy990Z5GyCe3SXz/J9LRDjCYaOd121vnEWf7ThjbPw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1655491787; a=rsa-sha256; cv=none; b=sH+eJnVG22rEwq+yzRhK2Q8MyudB3TIACkeYhZ2qRRVBzrJBLaw+63/5FH6enP0aO5auu5 LvPZdDDJprBVIwxzq6FCQiEZ9V+Q9u/915d9z+wQy1tn4FKqf161VB1P/7XWF0jvh/nSJF xWgSAF9RlUCjCWqR3j5Ybd8dJWofLyxg4VnZbkFJMvYRhbAhHCXI2iSm73WaHa/qXjOzSD pA86joz3Kjy+7cx5DaNg4SthAZkcvz/Q9sGLKjmX17N+kLLWxbRpUwHdBkvfkeZJ9jA2Wd KxVViPw4DFaCdsCe/0du29eCpZlcz8nBOM2ncDXjUetYGzmTkGEJ8Qn/GbDsMw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D264723 --- Comment #5 from Damjan Jovanovic --- "fsid" is widely used as the name for dev_t fields in sys/user.h: struct kinfo_file, struct kinfo_ovmentry, struct kinfo_vmentry, and struct kinfo_vmobject use it. I don't think we should rename. We are not changing the meaning of the fiel= d, we're changing a meaningless field to meaningful field. Code can only break= if it relies on meaningful values, but currently kl_file_fsid is meaningless, almost like an uninitialized variable. And it's only in CURRENT, so it can freely change. --=20 You are receiving this mail because: You are the assignee for the bug.=