From nobody Mon Jun 06 13:22:46 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 56D981BEE544 for ; Mon, 6 Jun 2022 13:22:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LGvLG6ptMz3h53 for ; Mon, 6 Jun 2022 13:22:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id C01C0269D3 for ; Mon, 6 Jun 2022 13:22:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 256DMkCM058847 for ; Mon, 6 Jun 2022 13:22:46 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 256DMkA0058846 for bugs@FreeBSD.org; Mon, 6 Jun 2022 13:22:46 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 264468] libc: fix possible integer underflow Date: Mon, 06 Jun 2022 13:22:46 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1654521767; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CpKmy794StKTAAxl4c54XT4/iIDnO3QCXRqESOoQBKw=; b=mquqyBHltCdf4Q9Fg8f4OXNo5cuH0F7l0JhL5zE0GDSE2o65Vas1HIhw/UEpj7Up5rwUTK UWmtZrlpXmtqHI34Lg15CK0LvS3jR2xM14jNA7knvNsXyD9T/tPbr44dxxwUGiDNowAaw0 3pd5Yov+d4BRVVw9N9IMIxSFTZQMFYEA/2a76qYnVKVfrAwYSIMnobi72Y+WqzPA39GptK aN5mdxoo/aKB+ZxrSmmadSPC3pVTO52J1aGPwwVXskTkheEZoo8nBXnCSC+DYIWbu8XQK/ NKVupL8XV1fIsxpIibSiwFHhb6shnhMziAxVNtJQOqcWYhJadE7fELN7K7qcPg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1654521767; a=rsa-sha256; cv=none; b=DNyyit0S/tSVgBwhvUkeFuP+aHozkeI+JTudo3Z9IE5JNMyHAK1lZK6gg2g/COLEXdwnXZ A/VTgTvqvwz8at6iWMMnnb9tcwzIH+GY00d/xMUL9SuR6UagX5Mt0oYIOG25T6RkZCvVbV PmKvMRTH7YrP3oQ32A7L7sjGRv4Mc0PmL/N+aROKEmmrnBk8NlPFPTUtFvkHEPoRIFqq9d uomrrUY2X8O1t6UFHB/+a4PZGpP1sSNBnp+vz5fxsft7V4J2/on5K9Acrm3I/DNM6q/+L+ wvQ6zudEwwftU4/yJZhIKGQx/eOLhgvxlt2ceV6iFinoMmAx9s7M/TBKoBucOg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D264468 Mark Johnston changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Open CC| |markj@FreeBSD.org --- Comment #1 from Mark Johnston --- In all three cases, orig_buf_size and buffer_size are unsigned. So in the comparison "orig_buf_size < buffer_size - sizeof(struct protoent) - sizeof(= char *)", if underflow occurs, the right-hand side will wrap around to a large v= alue and the comparison will evaluate to true, causing __proto_unmarshal_func() = to return an error. Also note that "buffer_size" is directly set by the calle= r, the generic NSS cache code starts the buffer size at NSS_CACHE_BUFFER_INITIAL_SIZE (1KB) and grows it. So, I don't quite see the problem here - can you explain further? BTW, the attached patch does not seem to compile. --=20 You are receiving this mail because: You are the assignee for the bug.=