From nobody Sun Jun 05 12:38:09 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id BAA871BD6547 for ; Sun, 5 Jun 2022 12:38:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LGGPG2413z3nM1 for ; Sun, 5 Jun 2022 12:38:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 0F01A12295 for ; Sun, 5 Jun 2022 12:38:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 255Cc9ot063802 for ; Sun, 5 Jun 2022 12:38:09 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 255Cc9Fv063801 for bugs@FreeBSD.org; Sun, 5 Jun 2022 12:38:09 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 264473] uverbs: Fix a race with disassociate and exit_mmap() Date: Sun, 05 Jun 2022 12:38:09 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: ruc_gongyuanjun@163.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1654432690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4nQRJjj8N0OQZxzJPdC8wjwLyqqTBcZgwr6SX14aGws=; b=FM6wkkeyXRnvW5yAa0abLTxSVmesAJuJe7+1VZNUnAHLkKnSHkh7CuSfzADcn6/nh0Anwp VuGN2OIVyJweHeZOfR6jMHEP78dk8mzLJgbI4/+q/Kra90rulafjfBXkd25UYudxciHjbn QvNp3gxNksgjy1370vipB2/tHfPER/EFV8dpdTTE2f87CX/hcepllKOqIQTveMtXI0J8uX WTtsb1+JpQsfno1jenxQLLySOgU4dZQkGrpZHSdn752vGkqD7KJhXFg38al873GUh2i0wA hLuSJXBMasAvUezSVchTbFjl4NXx+a8//KtYuZts/tBudTqWsRG6hqGm4QX2DQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1654432690; a=rsa-sha256; cv=none; b=utpibzaDUohgfn3bN1WwcN2BBfa6Z3p/0Lhqk2k6R1I4KvoldEaRtPxd6ZkPPzULc1gRHL IrgQHZX00zBHXqHv+xwPU+Vj4oGIMp2gz0VxGXjghnskHgg487RFgz5taht8PDYNmlSQEA /LUCkGiRF+8lt0KV0Mg/OnoNtmc8FYrLL1gGqGPbTOQxpIUu24xDjYTnC9+FIZvIkwlBbb C8AsmRTTtkO52Ppn3xpgqa6NlPF/4gW/LxWsCjd9AgUWC7cCRUFixJw/t4l4j2I1krByH7 +ftCWqp4gfJsRROlq9LugQUaUXVKuucD32YjxWhbSoMO7zh34j3Wbl7JWzJnIg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D264473 Bug ID: 264473 Summary: uverbs: Fix a race with disassociate and exit_mmap() Product: Base System Version: Unspecified Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: ruc_gongyuanjun@163.com Created attachment 234462 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D234462&action= =3Dedit a possible patch If uverbs_user_mmap_disassociate() is called while the mmap is concurrently doing exit_mmap then the ordering of the rdma_user_mmap_entry_put() is not reliable. The put must be done before uvers_user_mmap_disassociate() returns, otherwise there can be a use after free on the ucontext, and a left over entry in the xarray. If the put is not done here then it is done during rdma_umap_close() later. Add the missing put to the error exit path. --=20 You are receiving this mail because: You are the assignee for the bug.=