From nobody Sun Jun 05 12:32:08 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C2B9F1BD56BE for ; Sun, 5 Jun 2022 12:32:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LGGGJ6s63z3nDF for ; Sun, 5 Jun 2022 12:32:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id BC5AB11FD5 for ; Sun, 5 Jun 2022 12:32:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 255CW8p6062779 for ; Sun, 5 Jun 2022 12:32:08 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 255CW8LD062778 for bugs@FreeBSD.org; Sun, 5 Jun 2022 12:32:08 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 264472] ib_sysfs: use the correct unregister function Date: Sun, 05 Jun 2022 12:32:08 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: ruc_gongyuanjun@163.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1654432329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=p5RLHJ/aSySFIV8yfgaMR+KoP+6GK7X1gMESfu1WJCY=; b=wj3e7DxeEWYTzGVKPJQr96bZeeZIHySS1FAjRFkKuiRsaDYmWR4EkSNUNnP17t5nLYlAUY jxiV1SYmU1l8q1GxM0QlLfZFZVF3JbeAbNhxr9u+LEkFnWjPJQNXxlyyqH+g4+xx3+Bcp2 D8s5wzfNzfXO10/lDKX2JaTiGME1rptIZoBLN/00OHPQnAP2vyTXCRTG3SbBUIGPPtlOFi W4aX9tkorN2RSc0CAsi26rcq8U43TQ4nkPhJ9opca4KFE+AkqtxwOMEdNL5fj/91J5cyNi e8TjWYG7vGw0nAfXmyIeZrP9466bJACy1EZbTm/c89PXj/rci75798OgultYCQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1654432329; a=rsa-sha256; cv=none; b=d6pWlewGNTVTeTfUI4cjWqK9yCJD+PDImrW/LEoSlgZIf2jIfNQl/oRoycnSc9OmqkqQv7 v5cyjNYpZgyIp4bZJ4E7cdjrJo0MXsgobYJO6mdjPv20yVxnF4X50tLsS7tSR3MLLA5GgV S5iUfYm44jCoLadJB1PHCxw5FrVxL6Eix1FAVQnewDT+oaru3CuDNHmy6BMjV+CW8D+mre kkgU5AQdAU+WT19vfCnByMlPnXVuU483WxbVNpq4kA37Fdj9+BVq1cViWIHgt/MfIBxvnq llmWiwT+ugFj581TDKCRL7Z4+IQnBmsJpzGHsZ2XSComi8ojNjWMkfMjwzZllg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D264472 Bug ID: 264472 Summary: ib_sysfs: use the correct unregister function Product: Base System Version: Unspecified Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: ruc_gongyuanjun@163.com Created attachment 234461 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D234461&action= =3Dedit a possible patch In ib_device_register_sysfs, on the error path, device_unregister is called. device_register deletes the device, which will cause use after free. device_del should be called which undose device_add but not delete the device. --=20 You are receiving this mail because: You are the assignee for the bug.=