[Bug 265461] "skein* -q -c <string> <file>" command returns 0 exit code with '-q' and with incorrect skein string

From: <bugzilla-noreply_at_freebsd.org>
Date: Tue, 26 Jul 2022 20:45:13 UTC

Stefan Eßer <se@FreeBSD.org> changed:

           What    |Removed                     |Added
                 CC|                            |se@FreeBSD.org
 Attachment #235498|                            |maintainer-approval+
              Flags|                            |

--- Comment #4 from Stefan Eßer <se@FreeBSD.org> ---
Created attachment 235498
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=235498&action=edit
Make skein256 -q -c <hash> return 2 on mismatch

The man page does not state that skein256 -q -c <hash> should an return
non-zero exit status if the passed hash does not match the contents of the

But it seems obvious, that this was an oversight. If the -c option is ignored
if combined with -q, it should not be rejected to let the user know that the
combination is not supported.

The attached patch makes -q -c <hash> do what the man page says: it prints the
calculated hash. And it adds the exist status that results from the check
performed by the -c <hash> option.

You are receiving this mail because:
You are the assignee for the bug.