From nobody Wed Jan 05 18:19:33 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 7AFC319343F3 for ; Wed, 5 Jan 2022 18:19:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JTd6s1Kv8z3qPv for ; Wed, 5 Jan 2022 18:19:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 0B368113D8 for ; Wed, 5 Jan 2022 18:19:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 205IJWkk091473 for ; Wed, 5 Jan 2022 18:19:32 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 205IJWls091472 for bugs@FreeBSD.org; Wed, 5 Jan 2022 18:19:32 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 260958] pfctl: expand_rule: strlcpy Date: Wed, 05 Jan 2022 18:19:33 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: thomas@gibfest.dk X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1641406773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pbwrd/hTOwBuno0Ut5/se4TJlFVOyzje7J+c11SaPDs=; b=wni32Bc3cBX3FIPF9+nXyErrDYPoBI6yjTIO/tux4wBU+1yyCDc7rxLDt1Jsr1gyIBg24l rooQE+bzVao1Weyk/xSF8jFbkjXP5RlG6HkQkFeKHY8xXvfqBgH8rQb+khmJilRYd7sWdD c9WE2y2zYznalgSjivIP8pnlsUF3lO6I0pSMTnxnujnw3Zb3031l3ZQHQvCA2oOIs8KKqH oBbZcmdqHKkMORlnk9FlUOFNhoXMxXJ6kIB9mnJ1VetomiQ1fqyVyTWTfGt7KE3brvKG88 0ZQHuIEA+IKAxzv/yAeGHLYILvhbHovMFzWwMNgI1jdZW/o8ALY17UM+WAEduQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1641406773; a=rsa-sha256; cv=none; b=NwpiG1SJnW7Wwxs/vrSvdawXdNN8v9vHtIfWMoG/D3nWiBRuGwK04Flw+6kYXQWkzKRFvo OJqRRt7Q3M2CzcH70ixPMcPojJgVwbRXV6XRqUCKX9uY6HAhGEHRuaztQ85kfcH+dPPY2/ nYz3cys/HI0xgtFEVdKalC3a4jXzefs61pSSlxH7ObsyoY87iM1xti5TAFD61oa6Zwhqj1 H6KXYxCVxjBug8FHAo328NrFE2J3x/6aVBtymjJRsmyzitGFtVS/mAtTKvXs4XOJ79Xm/T uHLEJXY82TmbCllWhps7y/I55qxYjshBcotS5ezalbRNe9oG26grGvlc5r3ldg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D260958 Bug ID: 260958 Summary: pfctl: expand_rule: strlcpy Product: Base System Version: 13.0-STABLE Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: thomas@gibfest.dk Hello :) A fun bug where a long-ish ipv6 address used in a reply-to in a pf ruleset results in pfctl being unable to parse the ruleset. The issue boiled down to a one line ruleset, one with a 16 byte address (wh= ich fails) and the other with a 15 byte address (which works). [tykling@nuc1 ~]$ cat trigger=20 pass in reply-to { 2001:DB8:1234::5 } [tykling@nuc1 ~]$ pfctl -nf trigger=20 pfctl: expand_rule: strlcpy [tykling@nuc1 ~]$ echo $? 1 [tykling@nuc1 ~]$ cat notrigger=20 pass in reply-to { 2001:DB8:1234:: } [tykling@nuc1 ~]$ pfctl -nf notrigger=20 [tykling@nuc1 ~]$ echo $? 0 [tykling@nuc1 ~]$ uname -a FreeBSD nuc1.servers.bornhack.org 13.0-STABLE FreeBSD 13.0-STABLE #1 stable/13-d208638c5: Wed Jan 5 13:32:08 UTC 2022=20=20=20=20 root@nuc1.servers.bornhack.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC am= d64 [tykling@nuc1 ~]$=20 We first observed this on 12.2-STABLE a while back but I didn't get around = to reporting it until now, so I've just confirmed it is still an issue on a fr= esh 13-STABLE. Thanks! :) --=20 You are receiving this mail because: You are the assignee for the bug.=