From nobody Mon Jan 03 03:26:20 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C886D19275D5 for ; Mon, 3 Jan 2022 03:26:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JS1P84PvMz3Hpq for ; Mon, 3 Jan 2022 03:26:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 735891DEDA for ; Mon, 3 Jan 2022 03:26:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 2033QKrM041361 for ; Mon, 3 Jan 2022 03:26:20 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 2033QKub041360 for bugs@FreeBSD.org; Mon, 3 Jan 2022 03:26:20 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 260375] NFS server truncates directory cookies to 32-bits Date: Mon, 03 Jan 2022 03:26:20 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1641180380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bLUzaC8q7CXMs/Qf3wSzuqqc5QBoQUMz80WV/r0psSI=; b=B6lj5MV+I6ErxqYUMQwezncIVZJJ2l6Ww6jfU/0JJKq2Zp7jQYqq4YLuLZvOdxZZvJGTsZ h38W7bt9KfS7mnSXvRkQ6ZKe2c6f4A5GZELaregrarmCbBUhYRtNyJdLsT9ieb9xDswIZ8 ZVjMIEtww0zoU48JO9LGAhbsl063oR4Og0Yf9qz/8eRbcA6q/j6XEG2jVGWQM9kC169yjX pRHAx7Ts5G2MQHWtzobUrcTe6gol8w5y85sTtNSsx4GqFfHUhisybaDhFfPjjGniRbVxdr 9YrtOA/vIn062f7PJpvfKeYe2mE/KUtNvRU4wt4uyO0F5PRh4fT8Qu+JyS+LYg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1641180380; a=rsa-sha256; cv=none; b=peOtw/1dmOdMNbdHkS6vPaTGmoToNVnkY2SZVZglYYeFrGpR7KVhuOoIo06gKzvYeU7OCI fsNilPK2WH4xlqPcu/SiYNgVWdsgf9WPqd62zGwg2+vJBeGzySolMT6fBrHoa/phZfMkNd ONFBmCDdGQN35m7B8znHG9oAR1kfzYxhNmfV5tg6H71J8SagRz73pPDPw5sPVXzkeqPH9b gCjJZpb/7i99jiIKlrpipsR/5+45Faw+r6PwdoMTT+axM/10x1FNRNiBMlwMediLLcF8tH C+gEex8xWaNEvcmJ/k3gKpsKsZH4Qa+cq33CRgjceWacPxF0gQib3Y+abGK3pw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D260375 --- Comment #6 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D8ec62f06143a54dcb917cba4f24cf7c7a= 614265a commit 8ec62f06143a54dcb917cba4f24cf7c7a614265a Author: Alan Somers AuthorDate: 2021-12-13 03:57:14 +0000 Commit: Alan Somers CommitDate: 2022-01-03 03:09:15 +0000 nfs: don't truncate directory cookies to 32-bits in the NFS server In NFSv2, the directory cookie was 32-bits. NFSv3 widened it to 64-bits and SVN r22521 widened the corresponding argument in VOP_READDIR, but FreeBSD's NFS server continued to treat the cookies as 32-bits, and 0-extended to fill the field on the wire. Nobody ever noticed, because every in-tree file system generates cookies that fit comfortably within 32-bits. Also, have better type safety for txdr_hyper. Turn it into an inline function that type-checks its arguments. Prevents warnings about shift-count-overflow. PR: 260375 Reviewed by: rmacklem Differential Revision: https://reviews.freebsd.org/D33404 (cherry picked from commit 32fbc5d824f51f97220bc5c61a23e0bf3ff2b470) sys/fs/nfs/xdr_subs.h | 10 ++++++---- sys/fs/nfsserver/nfs_nfsdport.c | 13 ++++++------- sys/fs/nfsserver/nfs_nfsdsubs.c | 6 +++--- sys/nfs/xdr_subs.h | 12 +++++++----- 4 files changed, 22 insertions(+), 19 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=