From nobody Thu Feb 17 21:54:22 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 15BC019B9A51 for ; Thu, 17 Feb 2022 21:54:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K07rt5n9Qz3Qv5 for ; Thu, 17 Feb 2022 21:54:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id A35D111A67 for ; Thu, 17 Feb 2022 21:54:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 21HLsM7S060355 for ; Thu, 17 Feb 2022 21:54:22 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 21HLsMGg060354 for bugs@FreeBSD.org; Thu, 17 Feb 2022 21:54:22 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 262024] em(4)/iflib handles bad packets incorrectly Date: Thu, 17 Feb 2022 21:54:22 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: erj@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1645134862; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=X5V9QJDZRsNVSlt+aJwDLUv5fIEFA/0Ndmv9uxFasjU=; b=t1wL9x+t8cxCqmX8VPQruMFHzlP3fU/y5SsKXclnpc19usiYtDFqERBby5tsazblRxkliP +spgZZcY6XNuhknFBi3GvEkX7ynYoqtVTfdzOT85bW7rlm8MIWhe8V6WAFewVuqr00j6Vv gMSbFuPPxz8+uZNvuJVXSfFENflrB9M5uUUg/oQOpe2Iflzz5IEEY544YuE6/4aFObKk0M sPd6+eHkf5i/uu0y8w0Nngro6h8fFS0LeGJNnEFeLTbJmCSGgl2aTgnOh330tz9R03079z vCB6PV8CkXlTJvImIlSh08aFP7JManzl7a1Tb6BVwAfqDdbav3HnsbNJr0WlnQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1645134862; a=rsa-sha256; cv=none; b=CXBzIapIEt/FSXdJBn9VDu9Dq4FkOYLlBoIrWHWipVXTIUA5fU4iGpvw+cpt5LCPw7cWfs 99BkEOQXEMmV9qbUwZFPMV1Kf4x1OtGOsnksK9WKahNCturw2PIwHM6v0lLumXu6KsGsk6 dFhI70kkpBhuPgCx5S6dhjKmhaNTMpXQ6s9aSltwJfafANEOK9NMs6Lj7MuOj5wu6Polvt mjdIjGELgzDdmfM0XTRTmP7LU0e4YWmitHpMmqX2LBU72PmfEd+cdS05moPzEVnj771qEV 8RnNUnfJpbqJCg4qGVOzmLHW03mPyBqOxQyZYbl9JY5SUA3KMNVHYO7dZkgpVQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D262024 Bug ID: 262024 Summary: em(4)/iflib handles bad packets incorrectly Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: erj@freebsd.org We saw an issue where the em(4) interface would flap repeatedly, and the ro= ot cause was that the SBP flag was enabled, causing the hardware to send bad packets to the driver. It appears that if the driver's isc_rxd_pkt_get() handler (e.g. in em here: https://cgit.freebsd.org/src/tree/sys/dev/e1000/em_txrx.c#n692) returns EBA= DMSG (because the hardware said the packet was bad), the iflib function that cal= ls that will immediately jump to resetting the hardware. We don't think that this should be the case (especially if the driver is explicitly allowing bad packets) and think it should be changed. A previous bug report/commit changed the em(4) driver's default SBP setting= to false, so that future users probably won't encounter this behavior unless t= hey manually set it back to true. In this case we've seen it em(4) specifically, but it could affect other iflib-using drivers that allow hardware to forward bad packets to the drive= r. --=20 You are receiving this mail because: You are the assignee for the bug.=