From nobody Wed Feb 16 23:01:07 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 6024519B8E3B for ; Wed, 16 Feb 2022 23:01:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JzYNM0ltpz3vlv for ; Wed, 16 Feb 2022 23:01:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id EF8D41EA3F for ; Wed, 16 Feb 2022 23:01:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 21GN16Kb039841 for ; Wed, 16 Feb 2022 23:01:06 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 21GN16jm039840 for bugs@FreeBSD.org; Wed, 16 Feb 2022 23:01:06 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 261291] ESX NFS4.1 client hangs, server never responds to EXCHANGE_ID/CREATE_SESSION Date: Wed, 16 Feb 2022 23:01:07 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1645052467; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hje41j6R+IXwJJ+YeAac1PoJwxBgra5DjdlRQfOyD2I=; b=JkU+4VGJfsMSBC/6zA05eMnG2ZSDgkEalIIxB8C7I+L65UTmNYr7xLCjFDzGc96DArFAFM T+1nCa3lGfKA+TkwnWoYka8iOmBmdXlF5q+MM+GDrot0yiaHnCgfUSLnezbln5rn/WOzQL RVP/3LukIdCy8D0e0ftyfaXEaDI67uA9sWUAh1qnuE9/ViyeLplnL2DBBp80Lcm4JYjfcS 8q8RBcxdUyDJ3H8DCR8WCosArHlBhGbBzGdLXn/7GRAzBtkPOIFR/Ehjw3SuybG1qHfDOv WCA2IK4bAk5fZSsU8TTnCLz8fcW9HpmyeIHE67sG6pZNQdq3zxbpoFh6OoMStQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1645052467; a=rsa-sha256; cv=none; b=lPQKT1QHbbkbAaw7IQ5sIpNEgnxK7dc8b4VereHEDLotmUNWmIIaZ66rbGIFWPFeqBpNp4 W2Ay/oiSipqYRvGyLqjfOZVEAHHje+18Za1gL2SL2xdwpdUgubTb1ICRrEg1rlWxL0RpnO rRo2d1FGnpMV9ydbEnAKUCTVq+MQbrYc+OuCJn5v/7mUUUVT788JLQyMcbaUshWZUeR2Th QgZl/yG2JRmg/5/jz3fosNuo//4Jj8hdctmzk+vm4EyNGMaEJ+4nRfvBhdA5+fEGrdyS07 VC/57MNHHXV2/qI5FkEXBFchdzV3S7fd1qn9o7+FxoXr+insFg0ejJ3K3elJ7w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261291 --- Comment #22 from commit-hook@FreeBSD.org --- A commit in branch stable/12 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D95e95764918f97112bb05282d62d9777b= 706c2fb commit 95e95764918f97112bb05282d62d9777b706c2fb Author: Rick Macklem AuthorDate: 2022-02-09 23:17:50 +0000 Commit: Rick Macklem CommitDate: 2022-02-16 22:59:41 +0000 nfsd: Reply NFSERR_SEQMISORDERED for bogus seqid argument The ESXi NFSv4.1 client bogusly sends the wrong value for the csa_sequence argument for a Create_session operation. RFC8881 requires this value to be the same as the sequence reply from the ExchangeID operation most recently done for the client ID. Without this patch, the server replies NFSERR_STALECLIENTID, which is the correct response for an NFSv4.0 SetClientIDConfirm but is not the correct error for NFSv4.1/4.2, which is specified as NFSERR_SEQMISORDERED in RFC8881. This patch fixes this. This change does not fix the issue reported in the PR, where the ESXi client loops, attempting ExchangeID/Create_session repeatedly. PR: 261291 (cherry picked from commit 17a56f3fabdfacb62f6d8858643cdb1861c8c1b5) sys/fs/nfsserver/nfs_nfsdstate.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=