From nobody Sat Feb 12 21:37:14 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id F21F219B0D5B for ; Sat, 12 Feb 2022 21:37:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Jx3jQ5qZQz3r2P for ; Sat, 12 Feb 2022 21:37:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id A8EB56CDC for ; Sat, 12 Feb 2022 21:37:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 21CLbER3001923 for ; Sat, 12 Feb 2022 21:37:14 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 21CLbEu3001922 for bugs@FreeBSD.org; Sat, 12 Feb 2022 21:37:14 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 261446] freebsd-update should not create boot environment when it's not making changes to the boot environment Date: Sat, 12 Feb 2022 21:37:14 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1644701834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OMxHA4ve5ijlreljnFaStmrd6T2rma4AsSURdQOWMds=; b=whR/n4B0f2WycW8oQGatvCR56Qd6e/GB/Ogv9uzBbSu8G50UZtDSPUr4WljuiVl9tO1iA7 CpHWtP/Mn70h5Lu5DR0u8cXgCAsLXsYFL28BX31BB8HdFWSzS6/pPyw3Xv636YSCRngvQt z4Xaw532C23ZIHugDQRlYbDbe/HDYcnUgzWHzyKd9snZrCuDKNlZvC5gRoSAo68kcM7cXs e+LXxs/JvynVVg2twLzcyz0l/S3ge72dJ5zxrbnyNNcxTh7QM22BazKzJ7ISN+/aT9fcup TFbXcFRHJRm07M5yK6qtqwGlFcHzY+mP3FNga0faOBR4YLNdAh1NUBZoKX8t8g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1644701834; a=rsa-sha256; cv=none; b=mlANvvQj5LvGCwXVPmG4GwBi4kT+s+zDJ79TqAO0/QFXFlKEYjBFeb5qf6XcOP0qiZxr52 FTInOCXQpAzUvdWTXy7pdD6YcOPW6vcBM+RUTMsHYNTQnN/odZqS92n2HWIWDZJlQSvD0a or8t+7Iu4gPAtnbS3ioB5oAtTCpZ+BMzPNXjsk8Xb+O5MwxUCLumlaKbMiZ2z42Js77NKI Hlq0pDagw8+jfaop2CDIVaxxNxlcwhASR4DWRCQy3wNo9WJ0jf+JxQpDEy+xIw9NPj6DNu X4M0VgHwgaIVcXGsZVj4zIrA9XOnn4E8G1W/WFEwBFEnkUUUvm2iJTfkDKe0gg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261446 --- Comment #6 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3De01e8f911b935eabcc35b4d121951e4e2= 1042ee5 commit e01e8f911b935eabcc35b4d121951e4e21042ee5 Author: Kyle Evans AuthorDate: 2022-02-12 21:36:24 +0000 Commit: Kyle Evans CommitDate: 2022-02-12 21:36:24 +0000 freebsd-update: improve BE creation feature This addresses one nit and one bug in the BE creation feature of freebsd-update: The nit addressed is that it currently only names the BEs after the userland version, but the kernel version may be higher. After this change, we request both and pass them through sort(1) to choose the highest. This is especially helpful if a freebsd-update patch touched one but not the other. The bug fixed is that roots updated that are not located at '/', e.g., by using -b or -j, will no longer create boot environments automatically. There's a very low chance these will actually change the BE in any meaningful way, anyways. It could make sense in the future to allow an argument-override to create the BE anyways if someone comes up with a non-standard setup, e.g., where a jail is an important part of their boot environment on an appliance or some such setup. Half of this patch is submitted by delphij@, the other half kevans@. PR: 261446 MFC after: 3 days Reviewed by: delphij, emaste, Dave Fullard Differential Revision: https://reviews.freebsd.org/D34257 usr.sbin/freebsd-update/freebsd-update.sh | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=