From nobody Fri Aug 26 16:38:47 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MDls32XVdz4ZSFJ for ; Fri, 26 Aug 2022 16:38:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MDls31Xr5z3Kqn for ; Fri, 26 Aug 2022 16:38:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MDls30WNRzSXV for ; Fri, 26 Aug 2022 16:38:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 27QGcli8012428 for ; Fri, 26 Aug 2022 16:38:47 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 27QGclcQ012427 for bugs@FreeBSD.org; Fri, 26 Aug 2022 16:38:47 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 265974] SMR has several missing barriers Date: Fri, 26 Aug 2022 16:38:47 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1661531927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CjcWjn3pL3JYc7KcNW4yf7Zrp7a7FsGddNuipuhqo4M=; b=EiAsEGf5ZiS/HHvM80kvGplBQXCcPFQGfTTE6i3vy7OHsucL8xasFuCwZzemH9TnMdYkst xERdkA/hXZwvdC6y+TJdardBv7WvE33mtlNTfQvtlJS2pRPs60bvWPD9KXnpnuj14vDRqe rEMw0lGdGg4EcWT65FTEqD/s8i6EaQwqW7KzRAs0zShzC4cr7+EW+bKPPdsUYg+PouanOr VZR6FIybAangxyBNqJ2br5Lr0fbgaxaSNUfKVWnWVB2CRhSD37t/40B5LpALTs60hriLWl GcUlWxWZhVG9gSMH6rBoBpCmVAY1A3M7I59L/0OhgHbaKSwjuhVc8tOgQ52xVA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1661531927; a=rsa-sha256; cv=none; b=SgzF/wDRhZ7A3+jJuPwcMZ+OaS+MSO2rzcLvfh40+hH/X1AE2Om+FYExA5/3LdE4ZqSOUt H6JyONOtg//jMoY30TJkN94urOsrqGpwnrNYqpzOgNuLlMOU/f3xea35sjKje8Zvkve5P+ OHmWezro8PD9xnV1UYmdjE7VA3ApdM7SYU9LVc0IlEgyP4DwPsQBtbv7r0Z8tjvalxgeze IIZt5jX7e+24GGJuA2CPSfR3jfNAvoWXP+NQ2gZi+fq5RDvgFiL7aD9q1zwbTFnHTAIPi6 D19jpwUIOnuMXUxkqfeC742E5G60Nl0IYOEpfq0TLhI3iGXFuJEMOV0uaWao3w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265974 --- Comment #5 from Mark Johnston --- (In reply to Konstantin Belousov from comment #3) > That said, atomic_add_acq on x86 has the sequentially consistent semantic already (which is why you said that it works on Intel, right?). So the #ifdef from the patch in smr_enter() is not needed, use seq_cst fence for all arches. The ifdef makes some sense as an optimization. On x86 we can combine the s= tore and barrier into one instruction, so why not do that? --=20 You are receiving this mail because: You are the assignee for the bug.=