From nobody Thu Apr 21 19:58:08 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 791DD199F30D for ; Thu, 21 Apr 2022 19:58:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KkpHh6nkwz3NDc for ; Thu, 21 Apr 2022 19:58:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 9A66073AF for ; Thu, 21 Apr 2022 19:58:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 23LJw8Qb038046 for ; Thu, 21 Apr 2022 19:58:08 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 23LJw8KA038045 for bugs@FreeBSD.org; Thu, 21 Apr 2022 19:58:08 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 263407] RC3 Guided ZFS on root with encryption unmountable Date: Thu, 21 Apr 2022 19:58:08 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: misc X-Bugzilla-Version: 13.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1650571089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nNg4MZVvdPRJdqsIj5Q22N/1dgffAhRmo9tyZZIVVnI=; b=T6Cn90D3LoVFN4uG9i1HEIZ/RnzfWHalUvkFuWif7NkgDKarBrM/w4TGWlDUQ9XvJVsmU9 12Req0RO4r+V9KY/gHLvTgu2ljOPhkMH1j8v1wrOhnWnwaR+3/gQwPyXYKOMnP/uXh1UNM uMkTXvr1U5HA0z9DN/u4wlpuGx8SvqCn3NpdV5gI+qaBRF2t+AXtvYxNG9X2vM6Y8Ol5Pz kQ7pDIbkEfAGVvbVrvPNzNa3yTRW1h9oxtSwfzVtEInybUdi5jMxvxDr5psd8fdm27+E/A /8cmoFuk8t7RDPksGKwc+f4URZInr9G36jP8rVvAzVH5Rdd7BiKrU8Wcn5MR0g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1650571089; a=rsa-sha256; cv=none; b=jzxXKQQU1HoRPWwivM5XNAXtfui0PBVFaEhHeLO5UR8UM51+Rp0plConp2cZuLrX9EQ/wJ ltgVrnyKWAtWsXpuk6o0iC3kZ8MLq+90V7WmWJ3CwSy9mKc8FiPn6Qbn3ED5x/Z5lV9RjV A+pwVI5C6TWfnUmZU/K5Wi5F/otDn05CTop2DBibpBZyCEz6DLhfFrIoP5N5UxWPIMXvkr UmmzbTlU0+HwrWea5WUdzbhsKmHtFNtasz+05URo8e47bMp+0W2gmJZKqIMawaBXlJ7CBC hUwg0hVMFKEfirtVKf25VzarPK3Q4/qBrgrEgBWRzNXjxgSIB/8QfraOvtqqKg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263407 --- Comment #16 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D914dc91d12198352b7878a88d30e2a637= 3a936e1 commit 914dc91d12198352b7878a88d30e2a6373a936e1 Author: Kyle Evans AuthorDate: 2022-04-21 19:57:24 +0000 Commit: Kyle Evans CommitDate: 2022-04-21 19:57:24 +0000 stand: zfs: handle holes at the tail end correctly This mirrors dmu_read_impl(), zeroing out the tail end of the buffer and clipping the read to what's contained by the block that exists. This fixes an issue that arose during the 13.1 release process; in 13.1-RC1 and later, setting up GELI+ZFS will result in a failure to boot. The culprit is this, which causes us to fail to load geom_eli.ko as there's a residual portion after the single datablk that should be zeroed out. PR: 263407 Reviewed by: tsoome MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D35019 stand/libsa/zfs/zfsimpl.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) --=20 You are receiving this mail because: You are the assignee for the bug.=