From nobody Wed Apr 13 17:25:23 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id F2A451B35F42 for ; Wed, 13 Apr 2022 17:25:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KdqH73zR9z53NN for ; Wed, 13 Apr 2022 17:25:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 61D037FB9 for ; Wed, 13 Apr 2022 17:25:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 23DHPNVO089133 for ; Wed, 13 Apr 2022 17:25:23 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 23DHPN23089132 for bugs@FreeBSD.org; Wed, 13 Apr 2022 17:25:23 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 263262] prometheus_sysctl_exporter doesn't distinguish between metric types Date: Wed, 13 Apr 2022 17:25:23 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 13.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: asomers@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649870723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kkxehTysalfsAJiuY+TO5XtjeWZpyoNAIX6Hd94Mfps=; b=WyHr38pqMKvBSqZvQ0+nh1TuzR2eXIzxYf9q7N3T7nWn8O7ftbv0i3mvrmO7EJ5nocz1Ff 6xzz3Rj3FstIbY3Rg1XaHAvdGcApTmv+eWSyX3wKugP1j7Tn03JjKkDccwtITJZubVA28q dm59n/zKIE4FsI4tyTTayxcFOFEBTHgWSt4JiBECUCEPIwIINtZBu0phCbI+enJfT4lt/K KglM9gO/Pyb14xNJ1UzXSn/sUu0hOExb+fv9nQ4wIgo+qehn/yRLRm2rN9Vn4R+5U84Hmf DTBYg0CIIAWdy3YWqUldCFMnzYBTpIhCqmvx91vCTYxwt2bLDQ7whilk8bIP/A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1649870723; a=rsa-sha256; cv=none; b=UU5WNBG4TuOGQq5VZXNxgnJjbBuBsJovF3be5ZCUNagGwkJfVcPN118bgPADJdSPzEZ/qx nC9ajLHfw/5qxMBKei7Bj0PRaKyVdvcB4qLWzj1XbCYNTM5s1BW8sznf8Z39BZ5ordpbGN 5sF8gI/v4bdd1rSE7LKXlFGv9+u5AKumLgfscNNgPjsfNIAY7/tg6TSVioGPu/EIo4q0EX dlaucfvw88nReTyYHi03lW+A1G32XLZW4nb8N9PP6Cnb0nKOfK0BUyTMerHg2Wj6x7CynA 3ZHEFkPqimv6BRUClIwJrbkFSH6WSgZNf+9D+f49j4qYzLGrl99RnFxw5SZVhw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263262 Bug ID: 263262 Summary: prometheus_sysctl_exporter doesn't distinguish between metric types Product: Base System Version: 13.1-STABLE Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: asomers@FreeBSD.org Prometheus recognizes four fundamental metric types: Counter, Gauge, Histog= ram, and Summary. There are sysctls that correspond to at least three of those: kstat.zfs..misc.dmu_tx_assign: histogram kstat.zfs.dmu_tx.dmu_tx_dirty_over_max: counter vfs.zfs.arc.max: gauge By default Prometheus assumes that all metrics are of type Gauge unless the exporter says otherwise. So sysctls that are really counters (like dmu_tx_dirty_over_max) can't properly be queried in Grafana. Presumably the histogram type can't either, but I haven't tried with any of those. The exporter ought to publish the metric type, like this: # HELP sysctl_foo_bar description of foo.bar # TYPE sysctl_foo_bar counter sysctl_foo_bar 12345 I'm not sure how to fix this. It might require adding additional informati= on to sysctl(3) itself. --=20 You are receiving this mail because: You are the assignee for the bug.=