From nobody Sat Apr 09 22:31:31 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 98DB61A9951E for ; Sat, 9 Apr 2022 22:31:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KbVGD0rtXz4qT0 for ; Sat, 9 Apr 2022 22:31:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id F303922783 for ; Sat, 9 Apr 2022 22:31:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 239MVV58097988 for ; Sat, 9 Apr 2022 22:31:31 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 239MVVIk097987 for bugs@FreeBSD.org; Sat, 9 Apr 2022 22:31:31 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 263188] pw accepts an "illegal option" but completes the command without error Date: Sat, 09 Apr 2022 22:31:31 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 13.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: dclarke@blastwave.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649543492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6CtH2Pk2rc8OoYoYS/oa7Nz9RE6GMd8BYJIn2T9crtw=; b=XVNfGzy7yMpJVR+SwR6Xqs/BKweDko1OxCBqoCiE6fLcsWfaDci+z1Zc3Ssx8KV8enCgQN t1H4ELE4nOig52kpCzfxt4yPfLorgajjiXLuux3FPRvsOHBD+mtnqg8LDm9hXNbs22IQg2 lLuQ8aje3C1bQvzC4v01qpKK4gddD8PklB+FBQMFbiow8sKfUll7yytVMSwRXio7fQzDLG z/mZIJlGTl8q75PwbN5ydIoqVErPXoVoqIAZtGbLeW03bKUV7WUkbDER44zEMAkTNi5Tw6 73rIx/hpjNrN66oV4Wl8TrNWd0Ls6CNck8rfV5z2EM3dFMNxRxx0j99YJPstuA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1649543492; a=rsa-sha256; cv=none; b=Ej+xqijh5mqO1HkKB06ZLcV7pLySH65RenfE64OFmb3Uk3KFQVumVUtoUFMjGwMh4lt2e4 x0jEnVlw7hOCd373AXbNLwFOCFsEtYeLZTYNHHiFrYG4/SsOvB2RRLj9oXqRJ7fGLYL9LH ZeBuu+8wr0ywE1OUHL7xAD8SKoxCINRj8JC8hUW1/STSVYECahBTo9CVB51YVsnaw+TUpD RsTsfi7ksg0/TowG6GUDpAs0pdtk4rdBE8OQXwGAiJJPL/rurlV6RJYIkuIR6EgzhTVgCA /cgKDFFN17USwNXPBhGezGQ0MkxB8xfhYcnsvA98w9diulHY6yXqrhFOjUVDoQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263188 --- Comment #2 from Dennis Clarke --- Testing the exit status and error message on another system where I see that I may add a user reasonably :=20 # uname -apKU=20 FreeBSD callisto 13.0-RELEASE-p11 FreeBSD 13.0-RELEASE-p11 #0: Tue Apr 5 18:54:35 UTC 2022=20=20=20=20 root@amd64-builder.daemonology.net:/usr/obj/usr/src/amd64.amd64/sys/GENERIC= =20 amd64 amd64 1300139 1300139 #=20 # adduser Username: testdude=20 Full name: The Test Dude Uid (Leave empty for default): 54321 Login group [testdude]: devl Login group is devl. Invite testdude into other groups? []:=20 Login class [default]:=20 Shell (sh csh tcsh git-shell bash rbash nologin) [sh]:=20 Home directory [/home/testdude]:=20 Home directory permissions (Leave empty for default):=20 Use password-based authentication? [yes]:=20 Use an empty password? (yes/no) [no]:=20 Use a random password? (yes/no) [no]:=20 Enter password:=20 Enter password again:=20 Lock out the account after creation? [no]:=20 Username : testdude Password : ***** Full Name : The Test Dude Uid : 54321 Class :=20 Groups : devl=20 Home : /home/testdude Home Mode :=20 Shell : /bin/sh Locked : no OK? (yes/no): yes adduser: INFO: Successfully added (testdude) to the user database. Add another user? (yes/no): no Goodbye! #=20 # There we see a valid adduser and a home directory : # ls -lap /usr/home=20 total 35 drwxr-xr-x 5 root wheel 5 Apr 9 22:26 ./ drwxr-xr-x 16 root wheel 16 Feb 20 02:04 ../ drwxr-xr-x 4 admsys admsys 12 Mar 23 22:09 admsys/ drwxr-xr-x 8 dclarke devl 21 Apr 8 05:16 dclarke/ drwxr-xr-x 2 testdude devl 9 Apr 9 22:26 testdude/ #=20 Now delete the user and the home directory but with a wrong option : # pw userdel -n testdude -t pw: illegal option -- t # echo $? 0 # Above we clearly see a clean zero value exist status. # ls -lapb /usr/home total 35 drwxr-xr-x 5 root wheel 5 Apr 9 22:26 ./ drwxr-xr-x 16 root wheel 16 Feb 20 02:04 ../ drwxr-xr-x 4 admsys admsys 12 Mar 23 22:09 admsys/ drwxr-xr-x 8 dclarke devl 21 Apr 8 05:16 dclarke/ drwxr-xr-x 2 54321 devl 9 Apr 9 22:26 testdude/ #=20 # pw userdel -n testdude -r pw: no such user `testdude' # echo $? 67 #=20 # rm -rf /usr/home/testdude #=20 So yes the user was in fact deleted from the system but the command issues a strange message and a zero exit status whereas a more reasonable behavior would be to issue a non-zero exit status and do no change to the system.=20 --=20 Dennis Clarke RISC-V/SPARC/PPC/ARM/CISC UNIX and Linux spoken GreyBeard and suspenders optional I see different behavior on another system where the exit status is set to 67 but again the user is removed from the machine and the home directory remains :=20 # uname -apKU=20 FreeBSD callisto 13.0-RELEASE-p11 FreeBSD 13.0-RELEASE-p11 #0: Tue Apr 5 18:54:35 UTC 2022=20=20=20=20 root@amd64-builder.daemonology.net:/usr/obj/usr/src/amd64.amd64/sys/GENERIC= =20 amd64 amd64 1300139 1300139 #=20 # ls -lap /usr/home=20 total 27 drwxr-xr-x 5 root wheel 5 Apr 4 14:30 ./ drwxr-xr-x 16 root wheel 16 Feb 20 02:04 ../ drwxr-xr-x 4 admsys admsys 12 Mar 23 22:09 admsys/ drwxr-xr-x 8 dclarke devl 21 Apr 8 05:16 dclarke/ drwx------ 2 54321 testnfs 2 Apr 4 14:30 testdude/ #=20 # pw userdel -n testdude -t pw: illegal option -- t pw: no such user `testdude' # echo $? 67 #=20 # ls -lapb /usr/home=20 total 27 drwxr-xr-x 5 root wheel 5 Apr 4 14:30 ./ drwxr-xr-x 16 root wheel 16 Feb 20 02:04 ../ drwxr-xr-x 4 admsys admsys 12 Mar 23 22:09 admsys/ drwxr-xr-x 8 dclarke devl 21 Apr 8 05:16 dclarke/ drwx------ 2 54321 testnfs 2 Apr 4 14:30 testdude/ #=20 # pw userdel -n testdude -r pw: no such user `testdude' #=20 # ls -lapb /usr/home total 27 drwxr-xr-x 5 root wheel 5 Apr 4 14:30 ./ drwxr-xr-x 16 root wheel 16 Feb 20 02:04 ../ drwxr-xr-x 4 admsys admsys 12 Mar 23 22:09 admsys/ drwxr-xr-x 8 dclarke devl 21 Apr 8 05:16 dclarke/ drwx------ 2 54321 testnfs 2 Apr 4 14:30 testdude/ #=20 # rm -rf /usr/home/testdude/ # --=20 You are receiving this mail because: You are the assignee for the bug.=