[Bug 263124] sys/x86/isa/clock.c: lapic_calibrate_timer() in cpu_initclocks() breaks compiling for non-SMP

From: <bugzilla-noreply_at_freebsd.org>
Date: Thu, 07 Apr 2022 18:10:42 UTC

John Baldwin <jhb@FreeBSD.org> changed:

           What    |Removed                     |Added
                 CC|                            |jhb@FreeBSD.org,
                   |                            |markj@FreeBSD.org

--- Comment #1 from John Baldwin <jhb@FreeBSD.org> ---
Probably the code in clock.c needs to be conditional on DEV_APIC (device apic
on i386 sets this, and it is always on for amd64).

For your system you really want 'device apic' I suspect even if you don't want
'options SMP' as you get less IRQ sharing when using an I/O APIC in place of
the old 8259A PICs even on a UP system.

Also, at this point removing 'options SMP' doesn't really buy you anything as
we always compile the LOCK prefix in for atomic operations now.

You are receiving this mail because:
You are the assignee for the bug.