From nobody Tue Apr 05 14:38:32 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 7903F1A8DB0D for ; Tue, 5 Apr 2022 14:38:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KXqyJ4rkQz4ZQP for ; Tue, 5 Apr 2022 14:38:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 2207244B for ; Tue, 5 Apr 2022 14:38:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 235EcWNO023584 for ; Tue, 5 Apr 2022 14:38:32 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 235EcWud023583 for bugs@FreeBSD.org; Tue, 5 Apr 2022 14:38:32 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 261375] mrsas: Remove additional MPT command allocation for R1 FP IOs Date: Tue, 05 Apr 2022 14:38:32 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649169512; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HsY6UOa7dcPXFzhPurriCoVLelBjN1dgWLhcGRTUvk0=; b=db6BqOGvhfs0dF4oPEJ+ItSiWrEqFijXHeTx5eC4oQT/t+8pCKVJjcM4duqM+nyxU8B1bx 6BwXsNOYdipDvVKw5eByNw7LUKYc7XPVJGGhVIrbup8cMoM8a73Wl0aIfyhr2tbF9hCd52 K1BeTciA85343ygLV9xvflgHtseo4aXJfS22rEhK6TA+7Y5921qEYXkV2k9gcLOlcmWoil EJ0h2U2peWc3Hs72AgdzsMeptDrdD2Cx+yc2tiT4fIWRE2U7WnrdMURD0AxLGTe0OcOotj 1t+tk2W/H5hDugUSnVnBDRfGIIBI6VGBVeVKP2Lzw4xCKoOhn8GIbpYi5j5Z7A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1649169512; a=rsa-sha256; cv=none; b=HxN5Kd5IQ05It+uW8YyJEN50FhiBebI3yb7/ksMjk+H7q/kSHQN+kOYS5YBJHPCSZcVnPj JEb0ctL9eLJmqLn/pYRptKZFjm2uGcAGkM7hk67cGYyvXzc5csjY0vNHLuPTx2JC73nrp1 fr//4EKhjh52pJm/jEsoRNlQBtqcmIiGOynGgKiMEpQG9f8Th6l/N3rBaigGYaC7wWgj4s 1BPnXDpRFHx4sK+xZt/zKh0hg0LZ8I84McCwXkvWbgl+aq/f4n4S5L2MOSP2nW3UkE0fY0 m8WH+1ro5tayEPAbmSAeKl3hYb4mkrY1PmVy+0jPCZWSv7eAXhqYXCQ5et8t4Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261375 --- Comment #3 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D79c4c4be9618470711480f46ef2cd3a15= c00cdd2 commit 79c4c4be9618470711480f46ef2cd3a15c00cdd2 Author: Chandrakanth Patil AuthorDate: 2022-01-21 09:24:37 +0000 Commit: Warner Losh CommitDate: 2022-04-05 14:38:15 +0000 mrsas: if controller reset is in progress, refrain from firing DCMDs to firmware in shutdown If controller reset is in progress, at same time if system shutdown is issued then corresponding shutdown function in driver will be invoked where driver is waiting 15 seconds to complete the controller reset. If the reset is not complteted within that time frame driver will go ahead and fire cache flush and shutdown DCMDs which will end up accessing the the queues which are not initialized due to undergoing reset leads to FMU error in firmware. Fix: In shutdown function, if controller reset is not finished within 15 seconds than driver will return to the OS without firing any DCMDs. Reviewed by: imp PR: 261375 sys/dev/mrsas/mrsas.c | 1 + 1 file changed, 1 insertion(+) --=20 You are receiving this mail because: You are the assignee for the bug.=