[Bug 221854] makefs: Reject UFS labels that are too long to fit
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Thu, 30 Sep 2021 21:02:51 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221854 Piotr Pawel Stefaniak <pstef@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pstef@freebsd.org --- Comment #2 from Piotr Pawel Stefaniak <pstef@freebsd.org> --- In 2017, Ed imported option parsing from NetBSD so this patch no longer applies. While I support the improvement, it has the side effect that since all strings are handled like this: case OPT_STRARRAY: strlcpy((void *)options[i].value, val, (size_t) options[i].maximum); break; you can't be selective about which truncation is tolerable and which is not. Ed, maybe we should reject any and all truncation errors in this path? -- You are receiving this mail because: You are the assignee for the bug.