[Bug 225434] [patch] Treat set but empty environment variables as unset in /usr/libexec/phttpget

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225434

Florian Smeets <flo@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |flo@FreeBSD.org

--- Comment #5 from Florian Smeets <flo@FreeBSD.org> ---
It looks like iocage currently fails to successfully run "iocage update $jail"
because of this behavior. I think this iocage commit
https://github.com/iocage/iocage/commit/9e3f905c839b9e6dea561e5471a71bdf2ba979d1
is responsible for always setting HTTP_PROXY, even if it's empty on the host
system. It also gets set if you enter the jail using "iocage console $jail",
HTTP_PROXY is set to an empty string. 

I agree that iocage should be fixed in this case, but wouldn't it make sense to
either apply the patch so phttpget can cope with HTTP_PROXY being empty, or at
least print an error message?

In this case all you see is:

Fetching 2 metadata files... failed.

I'll create an issue on github for iocage and link to this comment, but I'd
like to see us improving phttpget in one way or the other.

Thanks,
Florian

-- 
You are receiving this mail because:
You are the assignee for the bug.