[Bug 258243] A lock related issue in function wpi_run

From: <bugzilla-noreply_at_freebsd.org>
Date: Fri, 03 Sep 2021 08:40:30 UTC

            Bug ID: 258243
           Summary: A lock related issue in function wpi_run
           Product: Base System
           Version: 13.0-STABLE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: kern
          Assignee: bugs@FreeBSD.org
          Reporter: dinghao.liu@zju.edu.cn

There is a lock issue in sys/dev/wpi/if_wpi.c. In function wpi_run(),
WPI_RXON_LOCK() is called after wpi_set_timing(), but its corresponding
WPI_RXON_UNLOCK() is not executed on failure of wpi_send_rxon(), which may
cause a deadlock. This code logic is similar with wpi_auth(), and in this
function we do not return on failure of wpi_send_rxon().

This bug is suggested by a static analysis tool, please advise.

You are receiving this mail because:
You are the assignee for the bug.