From nobody Thu Sep 02 13:20:30 2021 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 300001799EAC for ; Thu, 2 Sep 2021 13:20:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4H0hPV0jBmz4t6T for ; Thu, 2 Sep 2021 13:20:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 009FB19996 for ; Thu, 2 Sep 2021 13:20:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 182DKTa5062065 for ; Thu, 2 Sep 2021 13:20:29 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 182DKTS5062064 for bugs@FreeBSD.org; Thu, 2 Sep 2021 13:20:29 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 258211] /usr/src/lib/libsecureboot/verify_file.c:59:22: error: use of undeclared identifier 'SOPEN_MAX' Date: Thu, 02 Sep 2021 13:20:30 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: ohartmann@walstatt.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D258211 Bug ID: 258211 Summary: /usr/src/lib/libsecureboot/verify_file.c:59:22: error: use of undeclared identifier 'SOPEN_MAX' Product: Base System Version: 13.0-STABLE Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: ohartmann@walstatt.org For a while now, 13-STABLE is not willing to build if WITH_BEARSSL is enabl= ed in src.conf. Reporting this problem on the mailing list (CURRENT) did not h= ave the impact I wished for, so I tried to investigate it myself. Error: [...] =3D=3D=3D> libexec/rpc.sprayd (all) --- all_subdir_stand --- /usr/src/lib/libsecureboot/verify_file.c:59:22: error: use of undeclared identifier 'SOPEN_MAX' static int ve_status[SOPEN_MAX+1]; ^ /usr/src/lib/libsecureboot/verify_file.c:74:22: error: use of undeclared identifier 'SOPEN_MAX' if (fd >=3D 0 && fd < SOPEN_MAX) { ^ /usr/src/lib/libsecureboot/verify_file.c:78:12: error: use of undeclared identifier 'SOPEN_MAX' ve_status[SOPEN_MAX] =3D ves; ^ /usr/src/lib/libsecureboot/verify_file.c:98:19: error: use of undeclared identifier 'SOPEN_MAX' fd >=3D 0 && fd < SOPEN_MAX) ^ /usr/src/lib/libsecureboot/verify_file.c:100:20: error: use of undeclared identifier 'SOPEN_MAX' return (ve_status[SOPEN_MAX]); /* most recent */ ^ --- all_subdir_cddl --- --- all_subdir_cddl/lib/libzfs --- =3D=3D=3D> cddl/lib/libzfs (all) --- all_subdir_sbin --- --- all_subdir_sbin/geom --- =3D=3D=3D> sbin/geom (all) --- all_subdir_lib --- --- all_subdir_lib/libclang_rt/ubsan_standalone_cxx --- =3D=3D=3D> lib/libclang_rt/ubsan_standalone_cxx (all) --- all_subdir_stand --- 5 errors generated. *** [verify_file.pieo] Error code 1 It seems obvious, as the comparison between recent CURRENT, where the sourc= es build fine even with WITH_BEARSSL set and recent 13-STABLE, where world fai= ls to build due to the error indicated above, see for yourself, the constant is undefinied in 13-STABLE: On recent 13-STABLE: :/usr/src # grep -r SOPEN_MAX * lib/libsecureboot/tests/Makefile:XCFLAGS.verify_file +=3D -DSOPEN_MAX=3D64 lib/libsecureboot/verify_file.c:static int ve_status[SOPEN_MAX+1]; lib/libsecureboot/verify_file.c: if (fd >=3D 0 && fd < SOPEN_MAX) { lib/libsecureboot/verify_file.c: ve_status[SOPEN_MAX] =3D ves; lib/libsecureboot/verify_file.c: * @li ve_status[SOPEN_MAX] if ve_status_state is none lib/libsecureboot/verify_file.c: fd >=3D 0 && fd < SOPEN_MAX) lib/libsecureboot/verify_file.c: return (ve_status[SOPEN_MAX]); /* = most recent */ On recent CURRENT: [...] :/pool/sources/CURRENT/src # grep -r SOPEN_MAX * lib/libsecureboot/verify_file.c:#ifndef SOPEN_MAX lib/libsecureboot/verify_file.c:#define SOPEN_MAX 64 lib/libsecureboot/verify_file.c:static int ve_status[SOPEN_MAX+1]; lib/libsecureboot/verify_file.c: if (fd >=3D 0 && fd < SOPEN_MAX) { lib/libsecureboot/verify_file.c: ve_status[SOPEN_MAX] =3D ves; lib/libsecureboot/verify_file.c: * @li ve_status[SOPEN_MAX] if ve_status_state is none lib/libsecureboot/verify_file.c: fd >=3D 0 && fd < SOPEN_MAX) lib/libsecureboot/verify_file.c: return (ve_status[SOPEN_MAX]); /* = most recent */ lib/libsecureboot/tests/Makefile:XCFLAGS.verify_file +=3D -DSOPEN_MAX=3D64 --=20 You are receiving this mail because: You are the assignee for the bug.=