From nobody Tue Oct 12 14:56:14 2021 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4297D18061F8 for ; Tue, 12 Oct 2021 14:56:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HTJdV1H2Kz3KHT for ; Tue, 12 Oct 2021 14:56:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 0CE9416986 for ; Tue, 12 Oct 2021 14:56:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 19CEuDqs036432 for ; Tue, 12 Oct 2021 14:56:13 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 19CEuDvw036431 for bugs@FreeBSD.org; Tue, 12 Oct 2021 14:56:13 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 259105] ext2fs would be more robust if it checked the type of inode 2 Date: Tue, 12 Oct 2021 14:56:14 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rtm@lcs.mit.edu X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D259105 Bug ID: 259105 Summary: ext2fs would be more robust if it checked the type of inode 2 Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: rtm@lcs.mit.edu Created attachment 228627 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D228627&action= =3Dedit An ext2 file system with a damaged root i-node. ext2fs is willing to mount a file system whose root i-node is a symbolic link, which soon causes a panic. It would be better if ext2_root() or ext2_vget(ino=3D2) checked the inode type. I've attached a demo ext3 disk image, whose root i-node's mode says it is a symbolic link, and whose size is 60 bytes. # uname -a FreeBSD stock14 14.0-CURRENT FreeBSD 14.0-CURRENT #0 main-n248636-d20e9e02d= b3: Thu Aug 12 05:47:18 UTC 2021=20=20=20=20 root@releng1.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC amd64 # gunzip ext38.img.gz=20 # mdconfig -f ext38.img=20 md0 # mount -t ext2fs -o ro /dev/md0 /mnt # cp /mnt/a /dev/null panic: invalid lock request for crossmp cpuid =3D 0 time =3D 1634045804 KDB: stack backtrace: db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe0063aea= 5b0 vpanic() at vpanic+0x187/frame 0xfffffe0063aea610 panic() at panic+0x43/frame 0xfffffe0063aea670 crossmp_vop_lock1() at crossmp_vop_lock1+0xaf/frame 0xfffffe0063aea6b0 _vn_lock() at _vn_lock+0x54/frame 0xfffffe0063aea710 lookup() at lookup+0xc2/frame 0xfffffe0063aea7b0 namei() at namei+0x388/frame 0xfffffe0063aea870 kern_statat() at kern_statat+0x12d/frame 0xfffffe0063aea9c0 sys_fstatat() at sys_fstatat+0x2f/frame 0xfffffe0063aeaac0 amd64_syscall() at amd64_syscall+0x12e/frame 0xfffffe0063aeabf0 fast_syscall_common() at fast_syscall_common+0xf8/frame 0xfffffe0063aeabf0 --=20 You are receiving this mail because: You are the assignee for the bug.=