From nobody Mon Oct 04 09:58:41 2021 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id A4C8D17F4972 for ; Mon, 4 Oct 2021 09:58:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HNGPs48SHz4Tg4 for ; Mon, 4 Oct 2021 09:58:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 6F41C17689 for ; Mon, 4 Oct 2021 09:58:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 1949wfip061855 for ; Mon, 4 Oct 2021 09:58:41 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 1949wf7p061854 for bugs@FreeBSD.org; Mon, 4 Oct 2021 09:58:41 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 258914] g_label_ntfs_taste() doesn't validate data read from disk, can generate wild pointers Date: Mon, 04 Oct 2021 09:58:41 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rtm@lcs.mit.edu X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D258914 Bug ID: 258914 Summary: g_label_ntfs_taste() doesn't validate data read from disk, can generate wild pointers Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: rtm@lcs.mit.edu Created attachment 228428 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D228428&action= =3Dedit Disk or USB memory stick image that causes an infinite loop in the kernel. g_label_ntfs_taste() in sys/geom/label/g_label_ntfs.c reads from newly inserted disks (e.g. USB memory sticks that may be corrupt or malicious) and uses the data without validation to form pointers, which it dereferences. filerecp =3D g_read_data(cp, voloff, recsize, NULL); fr =3D (struct ntfs_filerec *)filerecp; for (ap =3D filerecp + fr->fr_attroff; atr =3D (struct ntfs_attr *)ap, atr->a_type !=3D -1; ap +=3D atr->reclen) { Whoever created the disk image controls atr->reclen, and thus can control the value of pointer atr. I've attached a disk image whose atr->reclen is zero, and which will generate an infinite loop in the kernel. Other values of atr->reclen cause kernel page faults. --=20 You are receiving this mail because: You are the assignee for the bug.=