Date: Thu, 20 May 2021 07:52:56 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256024 Bug ID: 256024 Summary: [zfs] `zpool upgrade' doesn't warn about updating bootloader anymore Product: Base System Version: 13.0-RELEASE Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: grembo@FreeBSD.org It seems like that while switching our upstream to OpenZFS, the following warning was lost after upgrading a zpool (e.g., `zpool upgrade zroot`): If you boot from pool 'zroot', don't forget to update boot code. Assuming you use GPT partitioning and da0 is your boot disk the following command will do it: gpart bootcode -b /boot/pmbr -p /boot/gptzfsboot -i 1 da0 I always liked that warning, as it reminded me not to forget this important step. At the same time I was also not so happy about the hardcoded example it gives (it only covers one specific setup). Therefore I would propose to get this feature back, but using a more generic text: In case you're booting from <poolname>, please make sure to update the bootcode according to your partition layout. See zfsboot(8) (`man zfsboot') for details. I didn't create a patch/code review yet, as I'm not sure how processes work when changing ZFS related code. I assume we try to keep the delta with OpenZFS as small as possible. This would also address bug #229595. -- You are receiving this mail because: You are the assignee for the bug.