From nobody Wed Jun 30 16:53:50 2021 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id D8D1C11D8133 for ; Wed, 30 Jun 2021 16:53:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GFS9B5lk5z4tWw for ; Wed, 30 Jun 2021 16:53:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id AF383109B0 for ; Wed, 30 Jun 2021 16:53:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 15UGrorA017102 for ; Wed, 30 Jun 2021 16:53:50 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 15UGrobG017101 for bugs@FreeBSD.org; Wed, 30 Jun 2021 16:53:50 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 256909] libucl upgrade in a0409676120c1e558d0ade943019934e0f15118d breaks ABI Date: Wed, 30 Jun 2021 16:53:50 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 12.2-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: michael.osipov@siemens.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D256909 Bug ID: 256909 Summary: libucl upgrade in a0409676120c1e558d0ade943019934e0f15118d breaks ABI Product: Base System Version: 12.2-STABLE Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: michael.osipov@siemens.com * I have installed a new FreeBSD host from 12.2-RELEASE image * Installed gitup(1): # fetch -o gitup.zip https://codeload.github.com/johnmehr/gitup/zip/main # unzip gitup.zip # cd gitup-main # mkdir -p /usr/local/etc /usr/local/sbin /usr/local/man/man1 /usr/local/man/man5 # make # make MK_DEBUG_FILES=3Dno DESTDIR=3D/usr/local BINDIR=3D/sbin MANDIR=3D/ma= n/man install # cd .. # rm -rf gitup* gitup makes use of ucl_iterate_object(). gitup works, it is now used to fetch a shallow copy of stable/12 to update = base from release to stable. After stable has been applied and the system has be= en rebooted gitup fails with undefined symbol "ucl_iterate_object". One needs = to recompile gitup to make it work again with stable/12. The reason is commit a0409676120c1e558d0ade943019934e0f15118d (libucl: vend= or import snapshort 20210314). In this specific commit the following has been performed: ... > -UCL_EXTERN const ucl_object_t* ucl_object_iterate (const ucl_object_t *o= bj, > - ucl_object_iter_t *iter, bool expand_values); > +UCL_EXTERN const ucl_object_t* ucl_object_iterate_with_error (const ucl_= object_t *obj, > + ucl_object_iter_t *iter, bool expand_values, int *ep); > + > #define ucl_iterate_object ucl_object_iterate > +#define ucl_object_iterate(ob, it, ev) ucl_object_iterate_with_error((ob= ), (it), (ev), NULL) ... > -ucl_object_iterate (const ucl_object_t *obj, ucl_object_iter_t *iter, bo= ol expand_values) > +ucl_object_iterate_with_error (const ucl_object_t *obj, ucl_object_iter_= t *iter, bool expand_values, > + int *ep) The dynamic symbol table has been modified and the symbol ucl_object_iterat= e is gone after base has been updated. This is a breaking change for me which I don't expect. While I can recompile gitup, no issue, others will have probl= ems with other ports which may rely on this symbol to exist. This also means th= at one cannot build this port in 12.2-RELEASE jail and use it in a 12-STABLE system. The vendor change must be modified that no macro is used, but the old symbo= l is retained and the replaced function simply calls the new one. --=20 You are receiving this mail because: You are the assignee for the bug.=