From nobody Thu Jun 17 19:51:30 2021 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 02BC75D19E8 for ; Thu, 17 Jun 2021 19:51:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4G5Xk96dCRz3mZn for ; Thu, 17 Jun 2021 19:51:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id CC158154C6 for ; Thu, 17 Jun 2021 19:51:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 15HJpT9X038808 for ; Thu, 17 Jun 2021 19:51:29 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 15HJpTaF038807 for bugs@FreeBSD.org; Thu, 17 Jun 2021 19:51:29 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 256677] libfetch pops for user credentials eventhough it does not support the auth mechanism Date: Thu, 17 Jun 2021 19:51:30 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 12.2-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: michael.osipov@siemens.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D256677 Bug ID: 256677 Summary: libfetch pops for user credentials eventhough it does not support the auth mechanism Product: Base System Version: 12.2-STABLE Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: michael.osipov@siemens.com Running on: stable/12:4e2ae05c3 Consider the following: > # curl https://deblndw011x.ad001.siemens.net/repos/websvn/ -I > HTTP/1.1 401 Unauthorized > Date: Thu, 17 Jun 2021 19:37:35 GMT > Server: Apache > X-Frame-Options: SAMEORIGIN > WWW-Authenticate: Negotiate > Content-Type: text/html; charset=3Diso-8859-1 fetch nags me: > # fetch https://deblndw011x.ad001.siemens.net/repos/websvn/ > Authentication required for ! > Login: libfetch does not support SPNEGO authentication through the Heimdal library= in base, yet it still nags me giving a false sense of support. The reason is here: https://github.com/freebsd/freebsd-src/blob/68d3790ba0bce162f9fcaed09cfecd9= adeab3943/lib/libfetch/http.c#L768-L796 It unconditionally sets cs.valid =3D 1 without even knowing whether it supp= orts the scheme or not. This needs to be changed to something: if at least one AS is supported set valid to 1 otherwise remain on 0. May this would do the trick: cs->valid =3D 0; if (strcasecmp(key, "basic") =3D=3D 0) { cs->challenges[cs->count]->scheme =3D HTTPAS_BASIC; cs->valid =3D 1; } else if (strcasecmp(key, "digest") =3D=3D 0) { cs->challenges[cs->count]->scheme =3D HTTPAS_DIGEST; cs->valid =3D 1; --=20 You are receiving this mail because: You are the assignee for the bug.=