From nobody Thu Jun 10 21:13:08 2021 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C2C417EC6C5 for ; Thu, 10 Jun 2021 21:13:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4G1Gsc52cdz4cN4 for ; Thu, 10 Jun 2021 21:13:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 956C416C29 for ; Thu, 10 Jun 2021 21:13:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 15ALD8Qo093556 for ; Thu, 10 Jun 2021 21:13:08 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 15ALD8qA093555 for bugs@FreeBSD.org; Thu, 10 Jun 2021 21:13:08 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 256542] vmstat -z output columns are not aligned Date: Thu, 10 Jun 2021 21:13:08 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: ghuckriede@blackberry.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D256542 Bug ID: 256542 Summary: vmstat -z output columns are not aligned Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: ghuckriede@blackberry.com Created attachment 225717 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D225717&action= =3Dedit Potential Fix vmstat -z currently has: - a missing space in the column header between SIZE and LIMIT - a missing space in the column header between FAIL and SLEEP - inconsistent column spacing between header and values for REQ, FAIL, SLEE= P, and XDOMAIN columns The included diff uses the following column sizes: - REQ is 8 bytes (could also be 4 bytes if libxo doesn't mind having values sized differently than 'requests' field name) - SLEEP is 5 bytes (to fit column name) - XDOMAIN is 7 bytes (to fit column name) N.B. Could also make SLEEP and XDOMAIN column sizes be 6 and 8, but then the default length would exceed 80 characters. Current output: # vmstat -z ITEM SIZE LIMIT USED FREE REQ FAILSLEEP XDOMAIN mbuf_packet: 256, 0, 0, 0, 0, 0, 0, = 0 mbuf: 256, 4946937, 1, 14, 1, 0, 0, = 0 mbuf_cluster: 2048, 772959, 0, 0, 0, 0, 0, = 0 mbuf_jumbo_page: 4096, 386479, 0, 0, 0, 0, 0, = 0 mbuf_jumbo_9k: 9216, 114512, 0, 0, 0, 0, 0, = 0 mbuf_jumbo_16k: 16384, 64413, 0, 0, 0, 0, 0, = 0 Output with diff applied: # vmstat -z ITEM SIZE LIMIT USED FREE REQ FAIL SLEEP XDOMAIN mbuf_packet: 256, 0, 0, 0, 0, 0, 0,= =20=20=20=20=20 0 mbuf: 256,4946937, 1, 14, 1, 0, 0,= =20=20=20=20=20 0 mbuf_cluster: 2048,772959, 0, 0, 0, 0, 0,= =20=20=20=20=20 0 mbuf_jumbo_page: 4096,386479, 0, 0, 0, 0, 0,= =20=20=20=20=20 0 mbuf_jumbo_9k: 9216,114512, 0, 0, 0, 0, 0,= =20=20=20=20=20 0 mbuf_jumbo_16k: 16384, 64413, 0, 0, 0, 0, 0,= =20=20=20=20=20 0 --=20 You are receiving this mail because: You are the assignee for the bug.=