[Bug 256538] [tcp] cc_algo:htcp is not NEWRENO:newreno

From: <bugzilla-noreply_at_freebsd.org>
Date: Thu, 10 Jun 2021 17:44:49 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256538

            Bug ID: 256538
           Summary: [tcp] cc_algo:htcp is not NEWRENO:newreno
           Product: Base System
           Version: 13.0-STABLE
          Hardware: amd64
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: bugs@FreeBSD.org
          Reporter: iron.udjin@gmail.com

Hello,

A few days ago after merge of changes to TCP RACK to 13-STABLE I've discovered
two problems:

1.

kernel config:
makeoptions WITH_EXTRA_TCP_STACKS=1
options TCPHPTS
options RATELIMIT

loader.conf:
cc_htcp_load="YES"
tcp_rack_load="YES"

sysctl.conf:
net.inet.tcp.cc.algorithm=htcp

After build stable/13-n245948-fc53b7269fed in dmesg I see constantly repeating
messages:
kernel: cc_algo:htcp is not NEWRENO:newreno

2.

If I disable INET6 in kernel config, kernel build fails with:

cc -target x86_64-unknown-freebsd13.0
--sysroot=/usr/obj/usr/src/amd64.amd64/tmp
-B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin  -O2 -pipe -O2 -pipe -march=native
-mtune=native -fno-common -DMODNAME=tcp_rack -DSTACKNAME=rack 
-fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -DKLD_TIED -nostdinc  
-DHAVE_KERNEL_OPTION_HEADERS -include
/usr/obj/usr/src/amd64.amd64/sys/IRON/opt_global.h -I. -I/usr/src/sys
-I/usr/src/sys/contrib/ck/include -fno-common  -fno-omit-frame-pointer
-mno-omit-leaf-frame-pointer
-fdebug-prefix-map=./machine=/usr/src/sys/amd64/include
-fdebug-prefix-map=./x86=/usr/src/sys/x86/include
-I/usr/obj/usr/src/amd64.amd64/sys/IRON     -MD  -MF.depend.rack.o -MTrack.o
-mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float 
-fno-asynchronous-unwind-tables -ffreestanding -fwrapv -Wall -Wredundant-decls
-Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith
-Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__
-Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas
-Wno-error-tautological-compare -Wno-error-empty-body
-Wno-error-parentheses-equality -Wno-error-unused-function
-Wno-error-pointer-sign -Wno-error-shift-negative-value
-Wno-address-of-packed-member -Wno-format-zero-length   -mno-aes -mno-avx 
-std=iso9899:1999 -c
/usr/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c -o rack.o
/usr/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:17676:8:
error: use of undeclared identifier 'isipv6'
                        if (isipv6)
                            ^
1 error generated.
*** Error code 1

Please let me know if you need any addition info.

-- 
You are receiving this mail because:
You are the assignee for the bug.