From nobody Thu Dec 16 03:55:55 2021 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E824618E6FAE for ; Thu, 16 Dec 2021 03:55:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JDyvb1Fwhz4jYg for ; Thu, 16 Dec 2021 03:55:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D896929151 for ; Thu, 16 Dec 2021 03:55:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 1BG3tsh0065152 for ; Thu, 16 Dec 2021 03:55:54 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 1BG3tscD065151 for bugs@FreeBSD.org; Thu, 16 Dec 2021 03:55:54 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 260375] NFS server truncates directory cookies to 32-bits Date: Thu, 16 Dec 2021 03:55:55 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1639626955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CHCWIHZJOH5GfnbNqTq7dvWdPLIcWn4lYX4KM3HTHok=; b=vyYYuplpv1XvrcHEGZTBhdRZsOJZ6gSX9xmw0hdzLZ/MPkBxkEAj9rWTozs6xitYWmborN MvEPzSPQ4lk6gwXcOd1mok9B7T8QDu01vmyGILV0z4+1igHaICaCAF9yU3ydPPRt6Ab8eR j4TKt+Q3+E2kStRFqqcFD//tvQspoxjjOzwt8nfeqkEfkDnJ4qpjDye2QD2H7SeJFvGrny aVtXbC4PrSD+7ctjKya+hkG7KqP3ftUSt8biKrcFOEHtCQUafxlHflhpY2uOpjr7slaRyC sALRMvoDeM8JuySfScaMyoyqdPqnj5dJOUBu6BMZvH2oqvxpOzADwNsKkRADHA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1639626955; a=rsa-sha256; cv=none; b=IMktm4AbVT5ykktzFWKogBOi+EKt6fEhn6ocjUgFfi1XV6pGbfESKxU0ODdo4IkHdEvdDY /9/UnV5Pr64plqdyywMj9GmDAWqHiIXcsgKLsAvNkPHkPgrWN6Vr9HVDahpxd2Y5FGTMRG mlDDmaZYe7bz91AEA4mRfLC0WY1zEYDNIsKrQCh+c2ZD2b9GY2ZyiA9XuxKBdx30bFSG24 M59QtruY0+soR4diW2ONuDjBEUk2f60ut/dfHZs63524pdjpkJSLJYp8NEWcBpJBY1reWN 1kZXQC9De3Fz2HhJxnYR4pxOaKhjCuBWEajYkPc8zqx3bxS+wuhH/93+jn0lAQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D260375 --- Comment #4 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D32fbc5d824f51f97220bc5c61a23e0bf3= ff2b470 commit 32fbc5d824f51f97220bc5c61a23e0bf3ff2b470 Author: Alan Somers AuthorDate: 2021-12-13 03:57:14 +0000 Commit: Alan Somers CommitDate: 2021-12-16 03:54:57 +0000 nfs: don't truncate directory cookies to 32-bits in the NFS server In NFSv2, the directory cookie was 32-bits. NFSv3 widened it to 64-bits and SVN r22521 widened the corresponding argument in VOP_READDIR, but FreeBSD's NFS server continued to treat the cookies as 32-bits, and 0-extended to fill the field on the wire. Nobody ever noticed, because every in-tree file system generates cookies that fit comfortably within 32-bits. Also, have better type safety for txdr_hyper. Turn it into an inline function that type-checks its arguments. Prevents warnings about shift-count-overflow. PR: 260375 MFC after: 2 weeks Reviewed by: rmacklem Differential Revision: https://reviews.freebsd.org/D33404 sys/fs/nfs/xdr_subs.h | 10 ++++++---- sys/fs/nfsserver/nfs_nfsdport.c | 13 ++++++------- sys/fs/nfsserver/nfs_nfsdsubs.c | 6 +++--- sys/nfs/xdr_subs.h | 12 +++++++----- 4 files changed, 22 insertions(+), 19 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=