From nobody Sun Dec 12 02:08:30 2021 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8D39F18D424C for ; Sun, 12 Dec 2021 02:08:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JBSjV2gw3z4WhG for ; Sun, 12 Dec 2021 02:08:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 382AC18DD3 for ; Sun, 12 Dec 2021 02:08:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 1BC28U6c041690 for ; Sun, 12 Dec 2021 02:08:30 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 1BC28UbH041689 for bugs@FreeBSD.org; Sun, 12 Dec 2021 02:08:30 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 260343] NFS client does not respect RLIMIT_FSIZE Date: Sun, 12 Dec 2021 02:08:30 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rmacklem@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1639274910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1yJWJ4aWR1vhoN74X8TjREgltlJCBlNYjJjXR4Ot04w=; b=OzYFEaHrh+RtzCgWwBag/bDmCMt5hXmu3Zo3zE1lsBJHDxKZ3yFxGsFLqqgOOeunFiNYDa BT9QNij9KiP5FiructuN9Pvfm/MrJn6dG9Scatpz2xYzZmPQ+0dD2dEhiGZ5bQkkFjOAAA 3xRLsGmoMwdGbUDQy5QudxQ6S6+g4UIg4Km29lsKQ6sghHNDqnwaZpUvGtZ8r9XEK91rZK Ys2jWIPVn+v4Icz7hPDI13BhGzeB7B078f68D+oEJY4VJqV4tlFsG5MZYhOmcHUOpVYP/T QvhOMyvALhcNWCZLejqiNp55ljlmWILG4j2Lei1mlkY19COYVSwA9TdtAXLUnA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1639274910; a=rsa-sha256; cv=none; b=ABe9Y7YnzYEMNdY0uUBqAivX50C1QBAyfAr6eq296AwSLJyUEBnKejNNnQV4UiAhqQjRj2 ji1eLNEIDEg13o/zjkunKY4g6N8AvmTfg/zFVwwpvaTOkfIlv6fX8cKkI1leCk5MXnen50 fc9ybYn8qrklRcsE528poMCgQxoBBNSmbHQZInZ7LdHnYiNlEZD8R1EezX6ppBfB/8oEEA r8cLUcppUGULLfsmtxSXPk0o7YxghAqw+F0SxHzkS2vpcfFfCUkTIrftBD8LHnNFtGUMDi rxehy1IikUUqvUDYutQLlnvl3yziWPRn8M8N7zanQaPqVjjGuvoZfvfnv3iWZA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D260343 --- Comment #1 from Rick Macklem --- Yep. I suppose vn_rlimit_fsize() should be called in nfs_allocate(). It should also be added to vop_stdallocate() to be consistent w.r.t. its use. (Note that VOP_SETATTR() of size does not check it and never has, for UFS, NFS,... It can grow the file size, although it does not allocate space.) Maybe use of RLIMIT_FSIZE needs to be discussed on a mailing list, to agree on what VOP calls should check it? --=20 You are receiving this mail because: You are the assignee for the bug.=