From nobody Wed Dec 08 21:58:11 2021 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 0D5D718C3847 for ; Wed, 8 Dec 2021 21:58:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J8WJ35T78z4R00 for ; Wed, 8 Dec 2021 21:58:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 9BD851ACC2 for ; Wed, 8 Dec 2021 21:58:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 1B8LwBP9079122 for ; Wed, 8 Dec 2021 21:58:11 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 1B8LwBKQ079121 for bugs@FreeBSD.org; Wed, 8 Dec 2021 21:58:11 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 260266] NFS callback RPC with negative taglen can crash client Date: Wed, 08 Dec 2021 21:58:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rmacklem@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: rmacklem@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to bug_status attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1639000691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6tpPjsijDfU3bsKbskT63Bq5Z2qUyzJBdVVSDp+5n0o=; b=yOENbr/kcwfbRVoMzzehErbkVRKPTq35Hm9OaQeIB1dKNnQnAMOOxMvNSc7RJoccIeOZpN GanakZNuYx5JW708idRI6ICCmNhY7vJXh5/z4fc0oX3JKYC0aMko9jLNscSueroVzHBizx rCbxlXdgHcmnz/3dkprbvflrHJ7foCwk1Xp3DRr6oDmjRyCHbTfZEFJNgVz3L9z1xfvqdN gElqqhhF+rRbg9EMGF8RKD04FVifU9tiExb48MsCNFOxph3ZFdmx9ry0Y93vsb7jOY0zFw YmvPLI3DBJ7Oqus937KN4ynJWqP0s4BJEJQOv6AjPxU9Z0I9GxXMCOXPWjWFDA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1639000691; a=rsa-sha256; cv=none; b=vLYe0EAvsoBtZV3txFFkVnF0m49NDqnGMa5f6uGaaNekDtL2ZZWwFz+KcV8a2lIv7qD6bC clkOgzeYfwyGueQq61BIfBsDEjWO0/F4JMdDAkS7PFUn9YjZI5s8gzL+BLz+am9IDQKvLG Yy8imLPV8vUTTykEL4mq34r2DjyqR3G6gGiC4JSf6BYXGf/GGdaBXkeai4+Ywghab2pwaB DENdxAJnBoFjrUqiwsjVo6uSRAiv65SHkZ1OjZreivJYEzKcyeZ92s7SvFbU270+sfVucj qmW0n1oJh7apAk3pZDs6ae0L9cyJs3kZFhgJP3+UTMrJjeDenWcnzoZpBGee0A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D260266 Rick Macklem changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugs@FreeBSD.org |rmacklem@FreeBSD.org Status|New |Open --- Comment #1 from Rick Macklem --- Created attachment 229981 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D229981&action= =3Dedit properly sanity check the callback taglen The sanity check for taglen in the callback request was incoorect in two ways. 1 - It did not check for an excessively large value. 2 - It did not set the taglen to -1 when the sanity check failed. This patch fixes the above and should stop the crashes. Maybe the reporter can confirm that the patch stops the crashes for them? --=20 You are receiving this mail because: You are the assignee for the bug.=