From nobody Wed Dec 08 09:00:45 2021 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 2935818C105D for ; Wed, 8 Dec 2021 09:00:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J8B320xW4z4gwF for ; Wed, 8 Dec 2021 09:00:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 17A49108F8 for ; Wed, 8 Dec 2021 09:00:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 1B890joi070953 for ; Wed, 8 Dec 2021 09:00:45 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 1B890jTM070952 for bugs@FreeBSD.org; Wed, 8 Dec 2021 09:00:45 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 260068] e1000 & igb in netmap mode removes VLAN headers Date: Wed, 08 Dec 2021 09:00:45 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.2-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1638954046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+ALhZYky9F5lm0YnKrVW1vMhAvBV6nN1kBhRR7uhLnE=; b=D5nMcq8x2o4H6ZnsisNf7rVmJRc8KRCAX8HGicYDQwn1Hbd8r9YZceYCES0oSPis0q/5f9 ZT8k3g4g4xz075d44YO/qXCgf34SPzo/40cFvvY6TNWrUR/waXijOJhau6hnMxILZu82uM p39DErPateV/SimUThIacAflByxuq0vkpe2S9ZHR0etQ48H2QMTRo0q0G9EyqzarNX6wa4 ui7XYnBmhoNZWr72YjUMYkNZV0htArQqm3nwD2GgXC58sliuYUSN+iXmYJVrxwlubATgeB dbgF+RQMUWXnw4DpNeIqnvCSdXtzVJ5cl7SfV//hqL+APPXiJyw2Y9kZuIH+rg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1638954046; a=rsa-sha256; cv=none; b=VUoXuF74r+wRMuztNfWM39PcT1XWy5+txV0r1AkMD30fR0mCY/rYsFiaGhGYRgTgWpi0Wo KTLKBg0jvksUR//bPbYjdiGB+jdt7BnBxYmcXrel1hI6dTXHl9i2rKvJ6vvtnrEqBgn/R1 l4ypv7NU4oUiR/XBErCidAfCjxcHkxC01iSPR+ECP89mnd5HChqlA9a0IvcItzUXnT9py9 FYXafvsQwjWp2rUNjGFuBSgYLq5076/45QIa3pcLqCH+GRLd6HE68asxhmlKPlVer48Vf3 YKShau7oeTveiNpCfKc5zsMv64Ac5A/OAFDrffTYSJnv+FMy1m+6yzpZbRWJvA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D260068 --- Comment #10 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3De0f4cdba533693bb6ef9d90243acdad89= 605b150 commit e0f4cdba533693bb6ef9d90243acdad89605b150 Author: Vincenzo Maffione AuthorDate: 2021-12-08 08:55:04 +0000 Commit: Vincenzo Maffione CommitDate: 2021-12-08 08:55:40 +0000 e1000: fix interface capabilities management The e1000 drivers (em, lem, igb) are currently looking at the iflib copies of the capabilities bitvectors (scctx->isc_capabilities and scctx->isc_capenable) rather than the ifnet ones (ifp->if_capabilities and ifp->if_capenable). However, the latter are the ones that are actually updated by ifconfig and that should be used by the drivers during interface operation. The former are set by the driver on interface attach (for iflib internal use) and should not be used anymore by the driver. This patch fixes the e1000 driver to use the correct bitvectors. PR: 260068 Reviewed by: markj MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D33154 sys/dev/e1000/if_em.c | 42 +++++++++++++++++++++++------------------- 1 file changed, 23 insertions(+), 19 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=