From nobody Tue Dec 07 18:52:37 2021 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 24F5218C6A82 for ; Tue, 7 Dec 2021 18:52:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J7qDP61Mxz4fGP for ; Tue, 7 Dec 2021 18:52:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id AF63B25188 for ; Tue, 7 Dec 2021 18:52:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 1B7Iqb6Q004417 for ; Tue, 7 Dec 2021 18:52:37 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 1B7IqbJ3004416 for bugs@FreeBSD.org; Tue, 7 Dec 2021 18:52:37 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 260266] NFS callback RPC with negative taglen can crash client Date: Tue, 07 Dec 2021 18:52:37 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rtm@lcs.mit.edu X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.mimetype attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1638903157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aiB6PclSstJJRPsEYPxogZsjU74PBzEkcnodtGvRY40=; b=CLVnrcoTsIr1jLOW9Vlxzp3YrzVhMWXDj3Kf+XLICKzGprbBukrdHqAh34T4+wF6fMfNUv i1klNw3kd4bOV4Cvrn7a9PSq3CqDX07Qn4s961kUMoJXceGF0b5xgPVcn4xg54V/Krz+O7 pkeyDX2zz/UnCK16aPxnxgFdec2iNQo8aid12j241SQ4pYvpsRsNw8bsu0YeSRqyfGzKyl uOfphLdK6XV/W4xA7fSogOYCCZwr9acK29+v00PyEBiby7zsSPelAy6LeKCBrlgaaaC43z 6NpDtVqcUCIkUBCKlKOdns5d9o19qzwcSEnLEZkmOfBv6YZ/qcYeFaRfoe6YaQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1638903157; a=rsa-sha256; cv=none; b=eZQVv0G0fXD6OtB6868FkQEP12EAquF8ZHjYPZbPiyDiz9Udrqb3qUcNxq3r9xvkoyJLQP oo5aKEdjptGj4Q75rfF9ojPAWs/TUF56qAV8vF0N1/w+O1U7/wkzrGHWKRHC4lk8rUVT3F aBA1TCFjMAvV/23Ob9UVXn6HnxqNYD/GBzODcvqNtdyM3jAYsaIOaZ5cQWcD3YVuhTdn59 AOk1jJHoWDbG8HcoLhlOvHcOX64/ihMCoXaE+RYTFXoIIBANBrkZKntBYHUCwwMyb/UpQ5 aVfv+D8OUZ6gvm96TR26wtsC55188TNqkOXdL9gG2fkptq/xoMMHIJcLAftW5g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D260266 Bug ID: 260266 Summary: NFS callback RPC with negative taglen can crash client Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: rtm@lcs.mit.edu Attachment #229961 text/plain mime type: Created attachment 229961 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D229961&action= =3Dedit Crash an NFS client with a callback with a bad taglen. nfscl_docb() has a few "goto nfsmout" before it initializes retopsp, but the code after nfsmout dereferences retopsp if taglen !=3D -1. I've attached a demo: # uname -a FreeBSD 14.0-CURRENT FreeBSD 14.0-CURRENT #130 main-n250909-08e6880c1a5c-dirty: Tue Dec 7 13:30:08 EST 2021=20=20=20=20 rtm@xxx:/usr/obj/usr/rtm/symbsd/src/riscv.riscv64/sys/RTM riscv # cc fnfs_6.c # ./a.out ... panic: Fatal page fault at 0xffffffc00021c200: 0000000000000000 --- exception 15, tval =3D 0 nfscl_docb() at nfscl_docb+0x1ac nfscb_program() at nfscb_program+0xee svc_run_internal() at svc_run_internal+0x810 svc_run() at svc_run+0x1a2 nfscbd_nfsd() at nfscbd_nfsd+0xce nfssvc_nfscl() at nfssvc_nfscl+0x204 sys_nfssvc() at sys_nfssvc+0xd0 do_trap_user() at do_trap_user+0x220 cpu_exception_handler_user() at cpu_exception_handler_user+0x72 --=20 You are receiving this mail because: You are the assignee for the bug.=