From nobody Sat Dec 04 22:56:05 2021 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C98C4182E698 for ; Sat, 4 Dec 2021 22:56:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J64mj4f2gz4Vty for ; Sat, 4 Dec 2021 22:56:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 7BBFE4E61 for ; Sat, 4 Dec 2021 22:56:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 1B4Mu5F8080593 for ; Sat, 4 Dec 2021 22:56:05 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 1B4Mu5D9080592 for bugs@FreeBSD.org; Sat, 4 Dec 2021 22:56:05 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 260128] "make tags" fails with "gtags not found", src/Makefile undesirably rewrites PATH Date: Sat, 04 Dec 2021 22:56:05 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: misc X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jfolker11@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1638658565; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AjUA2QZUO+Z4q6YRwpiXlwmV92FEt4L4EPjq0zRzHpU=; b=eXOdHphw+TKxRno61O4ITxYNNEpqt4fnKpuHT528rK8rnWTRun8F8Duk22+qUKbQZuysPg G0TlCJsNu93XVO5/pj9yY/jF948SYpmPevA4sv2E70TQkvp+9ZWcqJisLzcmvXk87G1D3j Msnp5zRrsd86KqoSxPhF7EnUmxnNhuZz9IauRdjqWYcclEQ6Z/A7/gE5lWJVB5zGWpxJJl DcY+zdWbhyMbWqoC7pPzyXbFmktNpE9D8wOItoNcaAOksfc01DDVO1kzqwPjHZAE5UK6f1 gR+o7uVRyymuPFsIryDNFFVlTiB1QM3xi40ZGnRV9LvUjuyv6+j5eJ3xQhIaFg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1638658565; a=rsa-sha256; cv=none; b=mnrs1s8sXUGRWUFGjkr+93rU4WaqcsbtAKskCWltU8kCpGcd39m4usGR/DMEXac8tr8P/K 2EOTQQZr5XiUoZZXAdc7mZTf2Z+Ss0oZIyRMozqJkuHE4GY/Obs5A7LpLU7VtWcZZSIkmO RFl6k4rAwOdnmFxSJOuAjK4QrK7XbwgLSjn5rsC7Ux23HqLcmWSFaI+TUcGPWy92zoESb+ O1tHIZbJ2cX+vM4iCkujm5N1lbjdv2Hhh//9AGASr4HeDmy/Z4oFDiFhqUgGOdti63j/zq HEBTI3HrQz5kRaDOFgZFLrY8XInS2T3dLkhduC3BPp2HchR81iD+01J+nuNEAA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D260128 --- Comment #7 from Jory Folker --- Alas! LOCALBASE is not set in bsd.dep.mk anywhere up the Makefile call chain for 'make tags'. Thus, I attached a proposed patch that sets 'LOCALBASE?=3D /usr/local' in t= he top-level Makefile, and one more time in bsd.dep.mk because: (a) I see this line in 4 other .mk files and 9 other Makefiles 2. Belt and suspenders. I maintain my protest that hardcoding PATH in a Makefile is not kosher for reasons outlined in comment #1 with extra emphasis on "DO NOT MESS WITH /root/.cshrc", but since leaving it alone has no practical implications, I'm content to make like Paul McCartney and let it be. --=20 You are receiving this mail because: You are the assignee for the bug.=